Skip to content

Plot.groupX({filter: () => true}) - #500

Closed
Fil wants to merge 6 commits into
mainfrom
fil/fill-groups
Closed

Fil wants to merge 6 commits into
mainfrom
fil/fill-groups

Conversation

@Fil

@Fil Fil commented Aug 13, 2021 •

Copy link
Copy Markdown
Contributor

follow-up on #499: using Plot.groupX({filter: () => true}…) creates empty points where there is no data

todo:

  • the code is a bit ugly
  • for feature parity with binX, the filter should receive the data, not just the index; and maybe the group too?
  • use InternSet
  • motivate with a meaningful example
  • use filter: "all" as a shorthand for {filter: () => true}?
  • optimize: we can probably sort once instead of sorting each group
  • optimize: probably no need to loop through X × Y if there is no filter
  • can probably do without sorting (ref. sort groups #414)

@mbostock

Copy link
Copy Markdown
Member

Yeah, nice, this is what I was imagining with the Cartesian product idea. Not sure how urgently we should tackle this but I like the direction. 🙂

Base automatically changed from mbostock/fix-empty-group to main August 13, 2021 17:08
@Fil

Fil commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

obsolete since v0.2!

@Fil Fil closed this Feb 6, 2023
@Fil
Fil deleted the fil/fill-groups branch February 6, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants