known keys for empty groups - #499
Merged
Merged
Conversation
mbostock
marked this pull request as ready for review
August 13, 2021 13:59
Fil
approved these changes
Aug 13, 2021
Fil
added a commit
that referenced
this pull request
Aug 13, 2021
…mpty points where there is no data
This was referenced Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When retaining empty bins,
b[0]will be undefined. However, since the bin can only possibly contain values in the current group, we may still know what the appropriate z, fill or stroke channel should be for the empty bin, and hence can propagate it.Needs testing, possibly optimization, and probably applies to the group transform, too.