Repository navigation
[10.0] Fix Regex.Replace to replace all matches - #4041
Merged
Merged
Conversation
Always include the global flag in regexp_replace and exercise multiple matches in existing replacement tests. (cherry picked from commit d747336) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: be8b4566-8a11-49cd-ad31-b208d3b0e2f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4040 for 10.0, cherry-picked from d747336 without changes.
.NET's
Regex.Replacereplaces all matches, but the PostgreSQL translation omitted thegflag and replaced only the first. Always appendginTranslateReplaceand strengthen the existing replacement tests with multi-match patterns. Shared option translation andRegex.Countare unchanged.Fixes #4035.
Validation: all 61 regex functional cases passed on .NET 10 with: