Repository navigation
Fix Regex.Replace to replace all matches - #4040
Merged
Merged
Conversation
Always include the global flag in regexp_replace and exercise multiple matches in existing replacement tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4633d5dd-172b-4c7a-ba3d-c19e02859860
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix covers both translated overloads and empty option flags with regression coverage; tests were not executed.
No open issues 🎉
What changed in this PR
Fixes #4035 by making PostgreSQL translation of Regex.Replace replace all matches, matching .NET behavior.
Changes:
- Always appends
gto replacement flags, including when other flags are empty. - Strengthens regression tests with multi-match patterns and updated SQL expectations.
- Leaves shared option translation and
Regex.Countunchanged.
| File | Description |
|---|---|
| test/EFCore.PG.FunctionalTests/Query/NorthwindFunctionsQueryNpgsqlTest.cs | Tests multi-match replacements across supported options. |
| src/EFCore.PG/Query/ExpressionTranslators/Internal/NpgsqlRegexTranslator.cs | Always supplies the global replacement flag. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET's
Regex.Replacereplaces all matches, but its PostgreSQL translation omitted thegflag and replaced only the first match, producing incorrect query results.Always append
ginTranslateReplace, including when the other options produce no flags. Shared option translation andRegex.Countare unchanged. Strengthen the existing replacement tests with multi-match patterns and update their SQL baselines.Fixes #4035