Repository navigation
fix(cli): bump the nirium dependency past the deprecated ^0.15.0 pin - #109
Merged
Merged
Conversation
Under semver on a 0.x package, `^0.15.0` means `>=0.15.0 <0.16.0` — it
excludes 0.16.0, confirmed with `semver.satisfies('0.16.0', '^0.15.0')
=== false`. A fresh `npm install` of nirium-cli has been resolving
nirium@0.15.0 since 0.16.0 shipped, missing everything that landed with
it (the pre-sign policy hook, the spend-cap error, the initMpp() fix).
Bumped to ^0.16.0 and regenerated package-lock.json for real (`npm
install` from a clean node_modules), not hand-edited — confirmed it
resolves nirium@0.16.0 both before and after a fresh install.
Pre-existing, not introduced by this change: npm warns that
@stellar/mpp@0.7.1 (nirium's own transitive dependency) peer-wants
@stellar/stellar-sdk@^15.1.0 while this package pins ^14.5.0 directly.
Verified the same warning fires identically with nirium@0.15.0 still
pinned — reverted the version bump locally and reran the install to
check. The CLI's own use of @stellar/stellar-sdk (Keypair.fromSecret,
just to print the public key) and nirium's internal use never share an
object across the package boundary — initX402() takes the secret as a
plain string, not a Keypair instance — so this warning doesn't appear to
be live-breaking today, but it's real and worth its own look separately.
Closes #102
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
|
No check ran here: both workflows filter by path ( Tested by hand instead, on current
Merging on that basis. Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com |
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102.
The bug
packages/cli/package.jsonpinned"nirium": "^0.15.0". Under semver ona 0.x package that range is
>=0.15.0 <0.16.0— it excludes 0.16.0.Confirmed:
semver.satisfies('0.16.0', '^0.15.0')isfalse. A freshnpm install nirium-clihas been resolvingnirium@0.15.0since 0.16.0shipped, silently missing everything in that release (the pre-sign
policy hook, the spend-cap error message, the
initMpp()fix).The fix
Bumped to
^0.16.0.package-lock.jsonregenerated for real —rm -rf node_modules && npm installfrom the changedpackage.json, not ahand-edit — and confirmed it resolves
nirium@0.16.0.Noted, not touched here
npm installwarns that@stellar/mpp@0.7.1(nirium's own transitivedependency) peer-wants
@stellar/stellar-sdk@^15.1.0, while thispackage pins
^14.5.0directly. I checked whether this bump introducesthat warning — it doesn't: reverted the version locally and reinstalled,
same warning fires identically against
0.15.0. The CLI only uses itsown
@stellar/stellar-sdkto callKeypair.fromSecret()for printing apublic key; the secret crosses into
nirium'sinitX402()as a plainstring, never a
Keypairinstance, so the two installed copies don'tshare an object across the boundary as far as I traced it. Real warning,
worth its own look, just not one this PR causes or fixes.
Verified
semver.satisfies('0.16.0', '^0.15.0')→false(the bug, confirmedprogrammatically before touching anything).
npm installresolvesnirium@0.16.0in the lockfile, bothimmediately after editing
package.jsonand again after a fullrm -rf node_modules && npm install.nirium pay --helpandnode --check bin/nirium.jsboth still runclean against the new install.
🤖 Generated with Claude Code