Repository navigation
Add single-host SMBv1 diagnostics for 2.14.213.48.21.3 - #83
Draft
netanelcyber wants to merge 5 commits into
Draft
netanelcyber wants to merge 5 commits into
netanelcyber wants to merge 5 commits into
Conversation
Added support for live SMBv1 and MS17-010 network scanners.
netanelcyber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing exports lack a normalized SMBv1 state, and the diagnostic runner has no SMBv1 protocol profile. Add offline export analysis and the opt-in
nmap_smbv1profile, and set package, project and standalone-core versions to the exact requested2.14.213.48.21.3.smb-protocolsscript. It defaults to dry-run, requires--mode active --scope-confirmed, bounds time/output, and uses the existing SQLAlchemy history and recovery path.NT LM 0.12evidence records support. Modern-only output recordsnot_observedwith unknown support; errors, timeouts, truncated or mismatched XML remain unknown. No authentication, exploit test or lateral-movement workflow is added.core.py, with host/provenance and unknown/conflicting states. Preserve LDAP/SPN and dashboard import/storage. Add missing dashboard category mappings for the diagnostic and the two names in the intervening registry commit6c874704; category mappings do not implement those tools.2.14.213.48.21.3below2.14.213.78.21.1, so installation requires selecting this exact version. See release notes.Validation: 414 tests and 265 subtests passed. Compilation, wheel/sdist builds, twine checks, isolated installed-wheel version/diagnostic dispatch and ORM persistence, and copied-core standard-library SMBv1/LDAP routes passed. Active negotiation is tested with fixtures; no external network target was scanned. GitHub Actions run 37298541167 passed on ubuntu-latest and windows-latest, including compilation, unit tests and the localhost dry-run. The published tree
ceb124982fd28bdd908b47bf6411f410d81d1b9eis identical to the validated local tree.PR #80: the nine shared patches were compared against #81/default
939bf787. The original LDAP/SPN implementation and tests are retained; no useful unique delta requires porting. Recommend closing #80 as superseded by #81. The file-by-file comparison is preserved. #80 remains unchanged.