Repository navigation
Add offline LDAP/SPN export analysis and repair version regression checks - #80
Draft
netanelcyber wants to merge 2 commits into
Draft
netanelcyber wants to merge 2 commits into
netanelcyber wants to merge 2 commits into
Conversation
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing LDAP/SPN JSON exports now produce structured offline reports containing SPN components, observed owner identities, account flags, advertised encryption types, timestamps and RootDSE metadata. Missing data and directory completeness remain explicit unknowns. The new --ldap-spn-data CLI route runs independently of the legacy scanner.
Stale version tests now check the current branch version, 2.14.78.21. CI runs pytest on Windows and Linux. Explicitly close test SQLite connections, normalize temporary paths and read source as UTF-8 so the existing ORM/source checks run reliably on Windows.
Validation: 295 tests and 293 subtests passed locally; GitHub Actions run 37190351384 passed on ubuntu-latest and windows-latest, including compilation, unit tests and localhost dry-run. IIS/EF6 execution remains unverified.
This draft contains the standalone data layer and test corrections. The separate PR #78 cleanup and proposed 2.14.213.78.21 source update remain in a local review proposal. core.py and dashboard execution are unchanged in this draft.