Repository navigation
fix: Receiver blocks stream would not query today - #987
Merged
Merged
Conversation
darunrs
marked this pull request as ready for review
August 6, 2024 03:19
darunrs
changed the title
Contributor
Author
|
Would like to get this one out to prod, since it can help speed up a lot of indexers. Will merge now and verify it works like expected in dev. Please review after the fact if needed! |
Merged
| let mut current_date = start_date; | ||
| let mut current_date = start_date | ||
| .with_hour(0) | ||
| .unwrap() |
Contributor
There was a problem hiding this comment.
Is it safe to do this? Can we handle None explicitly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current date used to start the receiver blocks backfill would have hour, minute, second, and nanosecond data. This meant when it reached today's date, it may potentially be ahead. This would lead to today not being queried. This PR fixes this by ensuring the current date is at the very start of the day, which guarantees it passes the <= check.