Repository navigation
Conversation
We've noticed that it is occasionally possible for the indexer config returned by the contract to be parseable/null with a success status code, even though the indexer itself was not in fact deleted. This triggers the deprovisioning workflow anyway, which currently throws the Indexer into a repairing state, where it is no longer operating. This PR updates the contract to retain configuration if the indexer was deleted. Coordinator will now expect a specific configuration to take deletion actions, instead of the previous method which left things open to interpretation. In the near future, the contract will be migrated (#964) to use an enum instead of contract format, to avoid wastefully storing things like code/schema for deleted indexers forever.
added events into launchpad.
…ing a new indexer and renamed BOS jsx elements (#973) JSX change + prettier
Added tests for fetching individual indexer config from registry contract. This was mostly an exercise to understand the behaviour of parsing registry contract responses, as well as understanding the changes that were made recently. A thin wrapper (`JsonRpcClientWrapper`) has been created to allow mocking of the JSON RPC Client responses.
Adds tests for: `DataLayerHandler`, `BlockStreamsHandler`, and `ExecutorsHandler`. No functional changes, but I did need to extract/create internal client wrappers so that the RPC requests can be mocked.
The current date used to start the receiver blocks backfill would have hour, minute, second, and nanosecond data. This meant when it reached today's date, it may potentially be ahead. This would lead to today not being queried. This PR fixes this by ensuring the current date is at the very start of the day, which guarantees it passes the <= check.
explore seems to be missing a few indexers and the reason was due to
pagination starting from 0. so on load it would grab the intial 50 and
then onclick for loadmore it would still grab the 0-50 already on
display.
fix: changes page to intialize to 1.
Initial Load (0-49) Indexers Loaded
First Click (page = 1): Loads indexers from 50 to 99.
Second Click (page = 2): Loads indexers from 100 to 149.
```
const handleLoadMore = () => {
const start = page * PAGE_SIZE; // FIRST: 1*50 = 50 -> SECOND: 2*50 = 100
const end = start + PAGE_SIZE; // FIRST: 50+50 = 100 -> SECOND: 100+50 = 150
const newIndexers = indexers.slice(start, end); // FIRST CLICK: 50-99 -> SECOND CLICK: 100-149
setCurrentPageIndexer([...currentPageIndexer, ...newIndexers]);
// FIRST: 0-49 + 50-99, SECOND: 0-99 + 100 - 149
setPage(page + 1);
};
```
Block streams are failing due to their start block being lower than the current. This PR fixes this issue by seeding the health task with the input start block. This should fix the issue in most cases. I've also ensured that the handoff between receiver_blocks and lake also do not repeat a block.
Contributor
Author
|
Prod contract deployment was successful. Tested list_all and that worked. Will do release before testing register/delete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.