Issue 490 by prisis · Pull Request #513 · narrowspark/framework

prisis · 2017-04-10T14:27:05Z

Q	A
Branch?	develop
Bug fix?	yes
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	no
Fixed tickets	#490
License	MIT

Nitpick-CI · 2017-04-10T14:27:18Z

+     * @var \Viserio\Component\Profiler\Profiler
     */
-    protected $webprofiler;
+    protected $Profiler


There must not be more than one property declared per statement

codecov · 2017-04-10T18:11:19Z

Codecov Report

Merging #513 into develop will decrease coverage by 2.55%.
The diff coverage is 54.51%.

@@              Coverage Diff              @@
##             develop     #513      +/-   ##
=============================================
- Coverage      88.19%   85.63%   -2.56%     
- Complexity      5036     5151     +115     
=============================================
  Files            399      403       +4     
  Lines          12586    12850     +264     
=============================================
- Hits           11100    11004      -96     
- Misses          1486     1846     +360

Impacted Files	Coverage Δ	Complexity Δ
...iler/DataCollectors/Bridge/PDO/TracedStatement.php	`0% <ø> (ø)`	`32 <0> (?)`
...t/Profiler/DataCollectors/PhpInfoDataCollector.php	`100% <ø> (ø)`	`12 <0> (?)`
...r/DataCollectors/Bridge/SwiftMailDataCollector.php	`60.71% <ø> (ø)`	`10 <0> (?)`
...ataCollectors/Bridge/PDO/TraceablePDODecorater.php	`4.83% <ø> (ø)`	`27 <0> (?)`
...io/Bridge/Twig/DataCollector/TwigDataCollector.php	`50.74% <ø> (-44.78%)`	`22 <0> (ø)`
...nent/Profiler/DataCollectors/TimeDataCollector.php	`89.39% <ø> (ø)`	`21 <0> (?)`
...dation/DataCollectors/NarrowsparkDataCollector.php	`100% <ø> (+94.11%)`	`10 <0> (ø)`	⬇️
src/Viserio/Component/Session/SessionManager.php	`96.77% <ø> (ø)`	`8 <0> (ø)`	⬇️
...mponent/Foundation/Bootstrap/LoadConfiguration.php	`95.23% <ø> (ø)`	`7 <0> (ø)`	⬇️
...ler/DataCollectors/Bridge/PDO/PDODataCollector.php	`40% <ø> (ø)`	`3 <0> (?)`
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9098f5...719086c. Read the comment docs.

# Conflicts: # src/Viserio/Bridge/Twig/Providers/TwigBridgeDataCollectorsServiceProvider.php # src/Viserio/Component/Foundation/Application.php # src/Viserio/Component/Foundation/Bootstrap/LoadConfiguration.php # src/Viserio/Component/Foundation/Bootstrap/LoadServiceProvider.php # src/Viserio/Component/Foundation/Bootstrap/RegisterStaticalProxys.php # src/Viserio/Component/Foundation/Bootstrap/SetRequestForConsole.php # src/Viserio/Component/Foundation/Console/Commands/KeyGenerateCommand.php # src/Viserio/Component/Foundation/DataCollectors/NarrowsparkDataCollector.php # src/Viserio/Component/Foundation/Http/Kernel.php # src/Viserio/Component/Foundation/Providers/ConfigureLoggingServiceProvider.php # src/Viserio/Component/Foundation/Tests/DataCollectors/NarrowsparkDataCollectorTest.php # src/Viserio/Component/Foundation/Tests/Http/KernelTest.php # src/Viserio/Component/Foundation/Tests/Providers/ConfigureLoggingServiceProviderTest.php # src/Viserio/Component/Parsers/Providers/ParsersServiceProvider.php # src/Viserio/Component/View/Engines/MarkdownEngine.php # src/Viserio/Component/WebProfiler/Providers/WebProfilerSwiftMailerBridgeServiceProvider.php

Nitpick-CI · 2017-04-23T18:54:24Z

+     *
+     * @return \Psr\Http\Message\ResponseInterface
+     */
+    public function getResponse($value='')


Incorrect spacing between argument $value and equals sign; expected 1 but found 0

Incorrect spacing between default value and equals sign for argument $value; expected 1 but found 0

Nitpick-CI · 2017-04-23T18:54:39Z

+     *
+     * @return \Psr\Http\Message\ResponseInterface
+     */
+    public function getResponse($value='')


Incorrect spacing between argument $value and equals sign; expected 1 but found 0

Incorrect spacing between default value and equals sign for argument $value; expected 1 but found 0

modified: src/Viserio/Component/Session/Store.php modified: src/Viserio/Component/Session/Tests/StoreTest.php

modified: src/Viserio/Component/Session/Tests/Middleware/VerifyCsrfTokenMiddlewareTest.php modified: src/Viserio/Component/Session/Tests/SessionManagerTest.php

modified: src/Viserio/Component/Session/SessionManager.php modified: src/Viserio/Component/Session/Tests/Middleware/StartSessionMiddlewareTest.php

modified: src/Viserio/Component/Session/Handler/CookieSessionHandler.php modified: src/Viserio/Component/Session/Middleware/VerifyCsrfTokenMiddleware.php modified: src/Viserio/Component/Session/Tests/Handler/CookieSessionHandlerTest.php modified: src/Viserio/Component/Support/Http/ClientIp.php

modified: src/Viserio/Component/Session/Middleware/StartSessionMiddleware.php modified: src/Viserio/Component/Session/Middleware/VerifyCsrfTokenMiddleware.php

some sessions changes Apply fixes from StyleCI fix first tests fix cookie handling working on session (#540) Refactor some old session code check if session is open and use http_only with true as default modified: src/Viserio/Component/Session/Middleware/StartSessionMiddleware.php modified: src/Viserio/Component/Session/Middleware/VerifyCsrfTokenMiddleware.php

Nitpick-CI · 2017-05-20T23:53:58Z

        return [
-            CacheManagerContract::class => [self::class, 'registerCacheFactory'],
-            CacheManager::class         => function (ContainerInterface $container) {
+            CacheManagerContract::class   => function (ContainerInterface $container): CacheManagerContract {


Expected 1 space after closing parenthesis; found 0

Nitpick-CI · 2017-05-20T23:53:58Z

+            CacheManagerContract::class   => function (ContainerInterface $container): CacheManagerContract {
+                return new CacheManager($container);
+            },
+            CacheManager::class           => function (ContainerInterface $container): CacheManagerContract {


Expected 1 space after closing parenthesis; found 0

Nitpick-CI · 2017-05-20T23:53:58Z

                return $container->get(CacheManagerContract::class);
            },
-            'cache' => function (ContainerInterface $container) {
+            'cache' => function (ContainerInterface $container): CacheManagerContract {


Expected 1 space after closing parenthesis; found 0

working on #490 part 1

Daniel Bannert and others added 2 commits April 10, 2017 16:22

fixes #493

c03534a

Apply fixes from StyleCI

d22e3c1

Nitpick-CI reviewed Apr 10, 2017

View reviewed changes

Daniel Bannert and others added 5 commits April 10, 2017 16:50

fix tests

28adabb

Apply fixes from StyleCI

3ecf239

fix names

cb67324

fix names

0301503

phpstan is happy

0b59739

prisis and others added 9 commits April 10, 2017 18:11

Apply fixes from StyleCI

466eb17

profiler fixes

c7c590e

working on profiler

c8bb66f

Apply fixes from StyleCI

9947520

Added new Event | Changed config names

cdb996f

Merge branch 'develop' into issue-490

4f5c799

changes

1e6d812

Apply fixes from StyleCI

0812775

Nitpick-CI reviewed Apr 23, 2017

View reviewed changes

changes

797c823

Nitpick-CI reviewed Apr 23, 2017

View reviewed changes

prisis and others added 9 commits April 24, 2017 00:32

fixed getCollectors

54a2b91

Apply fixes from StyleCI

33b408e

improving profiler css

f5c24b1

more changes

0becee2

Apply fixes from StyleCI

05c0bc3

changes

1b05fd0

Apply fixes from StyleCI

96edddb

Merge branch 'develop' into issue-490

752505a

readme update

f83b117

prisis and others added 23 commits May 20, 2017 02:34

Apply fixes from StyleCI

0537020

fixed some session bugs

7514d7f

modified: src/Viserio/Component/Session/Store.php modified: src/Viserio/Component/Session/Tests/StoreTest.php

Apply fixes from StyleCI

fc9a2ca

cs fix

e19e95e

and more session work

5517c0c

modified: src/Viserio/Component/Session/Tests/Middleware/VerifyCsrfTokenMiddlewareTest.php modified: src/Viserio/Component/Session/Tests/SessionManagerTest.php

Apply fixes from StyleCI

30b6f23

Apply fixes from StyleCI

2cfbcb4

Added tests for client ip

8e58f51

and more work

ed292e0

modified: src/Viserio/Component/Session/SessionManager.php modified: src/Viserio/Component/Session/Tests/Middleware/StartSessionMiddlewareTest.php

Apply fixes from StyleCI

30e5f64

fix composer

5e5d85a

some sessions changes

6f53c0a

modified: src/Viserio/Component/Session/Middleware/StartSessionMiddleware.php modified: src/Viserio/Component/Session/Middleware/VerifyCsrfTokenMiddleware.php

fixed some tests

e5ba2d1

Apply fixes from StyleCI

9219c83

added new datacollectors

602d145

Apply fixes from StyleCI

3166e1f

fix tests

627e1d8

small changes

b63bb9e

Apply fixes from StyleCI

7cc5db3

Added check for phpcache classes

55b35a7

Apply fixes from StyleCI

45b2836

Nitpick-CI reviewed May 20, 2017

View reviewed changes

happy phpstan

719086c

prisis merged commit 8034a60 into develop May 21, 2017

prisis deleted the issue-490 branch May 21, 2017 12:50

prisis added a commit that referenced this pull request May 22, 2017

Issue 490 (#513)

d1b15e2

working on #490 part 1

Navigation Menu

Repository navigation

Issue 490 - #513

Issue 490#513
prisis merged 109 commits into
developfrom
issue-490

prisis commented Apr 10, 2017

Uh oh!

Nitpick-CI Apr 10, 2017

Uh oh!

codecov Bot commented Apr 10, 2017 •

edited

Loading

Uh oh!

Nitpick-CI Apr 23, 2017

Uh oh!

Nitpick-CI Apr 23, 2017

Uh oh!

Nitpick-CI May 20, 2017

Uh oh!

Nitpick-CI May 20, 2017

Uh oh!

Nitpick-CI May 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

prisis commented Apr 10, 2017

Uh oh!

Nitpick-CI Apr 10, 2017

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Nitpick-CI Apr 23, 2017

Choose a reason for hiding this comment

Uh oh!

Nitpick-CI Apr 23, 2017

Choose a reason for hiding this comment

Uh oh!

Nitpick-CI May 20, 2017

Choose a reason for hiding this comment

Uh oh!

Nitpick-CI May 20, 2017

Choose a reason for hiding this comment

Uh oh!

Nitpick-CI May 20, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Apr 10, 2017 •

edited

Loading