This repository was archived by the owner on Mar 1, 2023. It is now read-only.
Repository navigation
working on session - #540
Merged
Merged
Conversation
prisis
commented
May 16, 2017
prisis
commented
Member
| Q | A |
|---|---|
| Branch? | Develop |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | #... |
| License | MIT |
| Doc PR | narrowspark/docs#... |
Codecov Report
@@ Coverage Diff @@
## develop #540 +/- ##
=============================================
- Coverage 88.23% 88.18% -0.05%
- Complexity 5016 5036 +20
=============================================
Files 400 399 -1
Lines 12560 12587 +27
=============================================
+ Hits 11082 11100 +18
- Misses 1478 1487 +9
Continue to review full report at Codecov.
|
prisis
added a commit
that referenced
this pull request
May 19, 2017
prisis
added a commit
that referenced
this pull request
May 20, 2017
some sessions changes Apply fixes from StyleCI fix first tests fix cookie handling working on session (#540) Refactor some old session code check if session is open and use http_only with true as default
prisis
added a commit
that referenced
this pull request
May 20, 2017
some sessions changes Apply fixes from StyleCI fix first tests fix cookie handling working on session (#540) Refactor some old session code check if session is open and use http_only with true as default modified: src/Viserio/Component/Session/Middleware/StartSessionMiddleware.php modified: src/Viserio/Component/Session/Middleware/VerifyCsrfTokenMiddleware.php
prisis
added a commit
that referenced
this pull request
May 22, 2017
prisis
added a commit
that referenced
this pull request
May 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.