Skip to content

[DSD-9516] move images from mosipdev to mosipqa - #1489

Merged
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1
Dec 18, 2025
Merged

abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1

Conversation

@gaganamadival

@gaganamadival gaganamadival commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated deployment image references for platform services.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Dec 18, 2025

Copy link
Copy Markdown

Walkthrough

The pull request modifies release/vidivi/images.txt to consolidate Docker image references. Three separate image entries (mosipdev/pmp-ui-v2:develop, mosipdev/partner-management-service:develop, mosipdev/policy-management-service:develop) are replaced with a single unified image (mosipdev/uitest-pmp-v2:develop).

Changes

Cohort / File(s) Summary
Image reference consolidation
release/vidivi/images.txt
Removed three image references and added one consolidated image reference (mosipdev/uitest-pmp-v2:develop)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Configuration file only; straightforward substitution of image references
  • No logic, behavior, or functional changes involved

Possibly related PRs

Suggested reviewers

  • Prafulrakhade
  • ckm007

Poem

🐰 Three images bundled into one so clean,
The simplest refactor ever seen!
Docker references dance and play,
Configuration shines bright today! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'move images from mosipdev to mosipqa', but the actual changes replace three mosipdev images with a single mosipqa image without completing the stated objective of moving all images. Update the title to accurately reflect the changes, such as 'DSD-9516 Replace PMP service images with uitest-pmp-v2 image' or clarify if the migration is incomplete.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e230aa and 931d808.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)

Comment thread release/vidivi/images.txt
mosipdev/pmp-ui-v2:develop develop
mosipdev/partner-management-service:develop develop
mosipdev/policy-management-service:develop develop
mosipdev/uitest-pmp-v2:develop develop

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# First, check if the file exists and examine its content
if [ -f "release/vidivi/images.txt" ]; then
  echo "=== File content with line numbers ==="
  cat -n "release/vidivi/images.txt"
  echo ""
  echo "=== File stats ==="
  wc -l "release/vidivi/images.txt"
else
  echo "File release/vidivi/images.txt does not exist"
  echo "Checking for related files..."
  find . -name "images.txt" -type f 2>/dev/null | head -20
fi

Repository: mosip/release-script

Length of output: 196


🏁 Script executed:

# Check git history for this file to see the changes
if [ -f "release/vidivi/images.txt" ]; then
  echo "=== Git log for the file ==="
  git log --oneline -n 10 -- release/vidivi/images.txt
  echo ""
  echo "=== Git diff (last commit) ==="
  git diff HEAD~1 HEAD -- release/vidivi/images.txt || git show HEAD:release/vidivi/images.txt
fi

Repository: mosip/release-script

Length of output: 265


🏁 Script executed:

# Look for git log messages that might contain PR title or context
git log --oneline -n 20 | head -20

Repository: mosip/release-script

Length of output: 119


Critical: Image registry doesn't match the migration intent stated in commit message.

The commit "[DSD-9516] move images from mosipdev to mosipqa" indicates the images should be migrated to the mosipqa registry, but the implementation still references mosipdev: mosipdev/uitest-pmp-v2:develop develop.

Update the image reference to use mosipqa registry to align with the stated migration goal, or clarify if the commit message was incorrect.

Additionally, confirm whether the duplicate develop string in mosipdev/uitest-pmp-v2:develop develop is intentional or a formatting error.

🤖 Prompt for AI Agents
In release/vidivi/images.txt around line 1, the image reference still points to
mosipdev and contains a duplicated "develop" token; update the registry from
mosipdev to mosipqa so the line reads the intended mosipqa image, and remove the
duplicate trailing "develop" if it is a formatting mistake (or if the second
word is intended as a tag or label, clarify its purpose and adjust to the
correct syntax like "mosipqa/uitest-pmp-v2:develop"). Ensure the final line uses
the correct registry and valid image:tag syntax and add a brief comment in the
commit message if the original commit message was incorrect.

@abhishek8shankar
abhishek8shankar merged commit 5513f21 into mosip:release-1.2.0.1 Dec 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants