Skip to content

[DSD-9180] image moved from dev to dev2 - #1348

Merged
Prafulrakhade merged 1 commit into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1
Nov 6, 2025
Merged

Prafulrakhade merged 1 commit into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1

Conversation

@gaganamadival

@gaganamadival gaganamadival commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Cleaned up and optimized release configuration by removing outdated backup versions of legacy credential, identity, and repository services to streamline deployment processes and reduce overall configuration complexity
    • Added new UI testing component for version 1.3.x to strengthen quality assurance capabilities and support more comprehensive end-to-end testing workflows

Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2025

Copy link
Copy Markdown

Walkthrough

The PR modifies the release/vidivi/images.txt configuration file by removing four Docker image entries tagged with release-1.2.3.x-backup and adding a new entry for the uitest-pmp-v2 image with release-1.3.x tag.

Changes

Cohort / File(s) Change Summary
Image Configuration Update
release/vidivi/images.txt
Removed four backup image entries (credential-service, credential-request-generator, id-repository-identity-service, id-repository-vid-service) from release-1.2.3.x-backup; added mosipdev/uitest-pmp-v2:release-1.3.x entry

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward configuration change with only removals and a single addition to an image manifest file
  • No logic or code changes involved

Possibly related PRs

  • release-script#1347: Main PR that introduced the four image entries with release-1.2.3.x-backup tags which are now being removed and replaced with the new uitest-pmp-v2:release-1.3.x entry.

Poem

🐰 Four backup bunnies hop away into the past,
As vidivi images change their masks,
In comes the new PMP v2 with style,
Release-1.3.x makes the roster smile! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions 'image moved from dev to dev2' but the actual changes show image entries being removed and different images being added, not a simple move between dev environments. Clarify the title to better reflect the actual changes: images were removed from one service while a different image was added. Consider a more specific title that explains which images were modified and why.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Prafulrakhade
Prafulrakhade merged commit 45ae51e into mosip:release-1.2.0.1 Nov 6, 2025
1 of 2 checks passed

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8974b8c and b624eeb.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)
🔇 Additional comments (1)
release/vidivi/images.txt (1)

1-1: Clarify change intent and verify removal of backup images.

The PR title suggests moving images "from dev to dev2," but the actual changes show version tag updates (removing release-1.2.3.x-backup entries and adding a release-1.3.x entry). Additionally, the source and target branches are identical (release-1.2.0.1), which is unusual for a PR.

Before merging, please verify:

  1. The purpose of removing the four backup images tagged release-1.2.3.x-backup and their current deployment status.
  2. Whether this is the correct target branch for this change or if it should be a different release branch.
  3. How the new uitest-pmp-v2:release-1.3.x image relates to the version 1.3.x release cycle.

Comment thread release/vidivi/images.txt
mosipdev/credential-request-generator:release-1.2.3.x-backup 1.2.3.x
mosipdev/id-repository-identity-service:release-1.2.3.x-backup 1.2.3.x
mosipdev/id-repository-vid-service:release-1.2.3.x-backup 1.2.3.x
mosipdev/uitest-pmp-v2:release-1.3.x release-1.3.x

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Trailing whitespace detected.

Line 1 appears to have trailing whitespace after release-1.3.x. Verify that this is intentional and consistent with the file format.

🤖 Prompt for AI Agents
In release/vidivi/images.txt around lines 1 to 1, the line
"mosipdev/uitest-pmp-v2:release-1.3.x release-1.3.x " contains trailing
whitespace after the second "release-1.3.x"; remove the trailing space (or
replace with a single newline if required by the format) so the line ends
exactly with the token and no extra whitespace, then save and commit the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants