Skip to content

[DSD-9452] mosipdev2 to mosipqa - #1460

Merged
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
SwapnilWorks-Devops:release-1.2.0.1
Dec 9, 2025
Merged

[DSD-9452] mosipdev2 to mosipqa#1460
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
SwapnilWorks-Devops:release-1.2.0.1

Conversation

@SwapnilWorks-Devops

@SwapnilWorks-Devops SwapnilWorks-Devops commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated image source references and version information in release configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
@coderabbitai

coderabbitai Bot commented Dec 9, 2025

Copy link
Copy Markdown

Walkthrough

Updates image references in the release configuration file by migrating from the mosipdev namespace to mosipdev2 and adjusting version token formatting. This is a data-level change affecting image mappings with no control flow modifications.

Changes

Cohort / File(s) Change Summary
Release image configuration
release/vidivi/images.txt
Replaces mosipdev/* image namespace with mosipdev2/* and adjusts version tokens from release-1.3.x release-1.3.x to release-1.3.x 1.3.x format across all entries

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward data migration with predictable pattern
  • Single file modified with uniform find-and-replace style changes
  • No logic, error handling, or control flow to evaluate

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 Hop along, dear mosipdev,
To mosipdev2, your version rev!
One-point-three, all dressed up anew,
Namespace magic—bing, bang, boo!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'mosipdev2 to mosipqa' but the actual change is replacing 'mosipdev/' with 'mosipdev2/', not converting to 'mosipqa'. The title misrepresents the actual changes. Revise the title to accurately reflect the change, such as 'DSD-9452 Update image references from mosipdev to mosipdev2' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 111cf8e and 218c417.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)
🔇 Additional comments (3)
release/vidivi/images.txt (3)

1-15: Verify that the version token format change is compatible with downstream tooling.

All entries were updated to change the second version token from release-1.3.x to 1.3.x (dropping the "release-" prefix). Ensure that any scripts, build pipelines, or tooling that parses this file can correctly handle the new format.

Can you verify:

  • Which downstream tools/scripts consume this file?
  • How does the second token field (version token) get used in image resolution or versioning logic?
  • Have tests been run to confirm the new format works end-to-end?

1-15: Confirm coverage of all affected services.

The file currently contains 15 registration-processor service entries. Please confirm:

  • Is this the complete set of services requiring the namespace migration?
  • Are there other image registry configuration files that also need to be updated for consistency?

1-15: This review comment is incorrect.

The actual commit message is "Image transfer: 15 completed, 00 failed to mosipdev2" — which matches the file content showing mosipdev2 references throughout. There is no mismatch between the PR title and the actual changes. The original comment incorrectly stated the PR title as "DSD-9452 mosipdev2 to mosipqa" when it actually refers to mosipdev2 in both the title and the code.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abhishek8shankar
abhishek8shankar merged commit 6ebf077 into mosip:release-1.2.0.1 Dec 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants