DSD-9251 - #1393
Conversation
WalkthroughA single container image reference in the release configuration file was updated, replacing the mosipdev2/apitest-inji-certify image with mosipdev/print and updating the version tag from 0.13.x to 1.3.x. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| mosipdev2/apitest-inji-certify:release-0.13.x 0.13.x | |||
| mosipdev/print:release-1.3.x 1.3.x | |||
There was a problem hiding this comment.
🧩 Analysis chain
Verify the rationale and impact of this image replacement.
This change replaces the image entirely—from mosipdev2/apitest-inji-certify:release-0.13.x to mosipdev/print:release-1.3.x—which is a substantial change involving a different repository, organization, and version. This is not a routine version bump.
Before merging, confirm:
- Intentionality: Is this image swap intentional, or was the wrong image reference edited?
- Old image removal: Verify that
mosipdev2/apitest-inji-certifyis not still required elsewhere in the codebase or release artifacts. - New image readiness: Ensure
mosipdev/print:release-1.3.xexists, is properly tested, and is ready for production use in release-1.2.0.1. - Rationale: Document why this specific image replacement is necessary in this release.
🏁 Script executed:
#!/bin/bash
# Description: Verify old image reference is not used elsewhere in the repository
echo "=== Checking for remaining references to old image ==="
rg -i "apitest-inji-certify" --type=txt --type=yaml --type=yml
echo -e "\n=== Checking for references to old org (mosipdev2) in images ==="
rg "mosipdev2" --type=txt --type=yaml --type=yml | grep -i image || echo "No other mosipdev2 references found"
echo -e "\n=== Listing all image.txt or image-related config files ==="
fd -e txt -e yaml -e yml | grep -i image | head -20Length of output: 325
🏁 Script executed:
#!/bin/bash
# Description: Verify old image references with corrected rg syntax and examine image files
echo "=== Checking for remaining references to old image (corrected) ==="
rg -i "apitest-inji-certify" || echo "No references to apitest-inji-certify found"
echo -e "\n=== Checking for references to old org (mosipdev2) ==="
rg "mosipdev2" || echo "No references to mosipdev2 found"
echo -e "\n=== Content of release/vidivi/images.txt ==="
cat release/vidivi/images.txt
echo -e "\n=== Content of release/checks/images.txt ==="
cat release/checks/images.txt
echo -e "\n=== Searching for any references to 'print:release' image ==="
rg "print:release" || echo "No other print:release references found"
echo -e "\n=== Searching for version 1.3.x references ==="
rg "1\.3\.x" || echo "No 1.3.x references found"Length of output: 9098
🏁 Script executed:
#!/bin/bash
# Description: Understand purpose of vidivi/images.txt and context of this change
echo "=== Content of release/vidivi/README.md ==="
cat release/vidivi/README.md 2>/dev/null || echo "README.md not found"
echo -e "\n=== Checking for any documentation about images.txt purpose ==="
fd -e md | xargs grep -l "images.txt" 2>/dev/null || echo "No docs mention images.txt"
echo -e "\n=== Looking for configuration or scripts that use vidivi/images.txt ==="
rg "vidivi.*images" || echo "No references to vidivi images.txt usage"
echo -e "\n=== Checking transfer_report.md for full context ==="
cat release/vidivi/transfer_report.md 2>/dev/null | head -50
echo -e "\n=== Search for print service references in production ==="
rg "print" release/checks/images.txtLength of output: 15110
Version mismatch detected: vidivi will transfer image version 1.3.x, but production release expects 1.2.0.
This change updates vidivi/images.txt to transfer mosipdev/print:release-1.3.x to the staging registry. However, the production configuration (release/checks/images.txt) specifies mosipid/print:1.2.0 for release-1.2.0.1. This version mismatch will cause the wrong image to be deployed during the release.
The transfer report from Nov 18 shows the previous image was just successfully staged, and this configuration update will cause the next vidivi run to transfer an incompatible version (1.3.x instead of 1.2.0).
Correct release/vidivi/images.txt to use mosipdev/print:1.2.0 to align with the production image list, or clarify why a higher version should be used for this release.
🤖 Prompt for AI Agents
In release/vidivi/images.txt around lines 1 to 1, the image entry was changed to
mosipdev/print:release-1.3.x which mismatches production's expected
mosipid/print:1.2.0; revert or update this entry to the correct image tag by
replacing mosipdev/print:release-1.3.x with mosipdev/print:1.2.0 (or, if this
release intentionally requires 1.3.x, add a clear justification comment and
coordinate updating release/checks/images.txt and the deployment config to
accept mosipdev/print:1.3.x so the vidivi transfer and production lists remain
aligned).
2 participants
Summary by CodeRabbit