[DSD-9246] mosipdev to mosipdev2 - #1380
Conversation
Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
WalkthroughThis pull request updates a container image reference in the release configuration file. The change replaces the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| mosipdev/apitest-mimoto:release-0.20.x release-0.20.x | |||
| mosipdev/apitest-inji-certify:develop develop | |||
There was a problem hiding this comment.
🧩 Analysis chain
PR title and implementation mismatch: expected mosipdev2/ but found mosipdev/.
The PR title indicates a migration from mosipdev to mosipdev2, but the actual change still references mosipdev/ instead of mosipdev2/. Additionally, the line format mosipdev/apitest-inji-certify:develop develop appears to have "develop" repeated, which may indicate a formatting error or require clarification on the intended file format.
Please verify:
- Should this be
mosipdev2/apitest-inji-certify:develop(matching the PR title)? - Is the duplicate "develop" tag intentional, or should the line be formatted differently?
- What is the expected format for entries in this
images.txtfile?
🏁 Script executed:
#!/bin/bash
# View the complete images.txt file to understand context and format
echo "=== Full content of release/vidivi/images.txt ==="
cat release/vidivi/images.txt
echo -e "\n=== Git diff for this file ==="
git diff HEAD release/vidivi/images.txt || git diff release/vidivi/images.txt
echo -e "\n=== Looking for other images.txt files or similar patterns ==="
find . -name "images.txt" -o -name "*images*" -type f 2>/dev/null | head -20
echo -e "\n=== Checking git log for context on this file ==="
git log --oneline -n 5 -- release/vidivi/images.txt 2>/dev/null || echo "No git history available"Length of output: 544
🏁 Script executed:
#!/bin/bash
# Check the sibling images.txt for format reference
echo "=== Content of release/checks/images.txt ==="
cat release/checks/images.txt
echo -e "\n=== Try showing file with git show (current commit) ==="
git show HEAD:release/vidivi/images.txt 2>/dev/null || echo "Not in HEAD"
echo -e "\n=== Show all files changed in this commit ==="
git diff --name-only HEAD 2>/dev/null || git diff --name-only 2>/dev/null || echo "Unable to get file list"
echo -e "\n=== Try to see the actual change with git show on the file ==="
git show --stat 2>/dev/null | head -30
echo -e "\n=== Check if there's a PR description or branch info ==="
git branch -vv 2>/dev/null || echo "No branch tracking"Length of output: 3474
🏁 Script executed:
#!/bin/bash
# Show the actual diff to see what changed (before and after)
echo "=== Git show with actual diff for the file ==="
git show bc6a17c -- release/vidivi/images.txt 2>/dev/null || git show HEAD -- release/vidivi/images.txt
echo -e "\n=== Show previous version ==="
git show bc6a17c~1:release/vidivi/images.txt 2>/dev/null || echo "Previous version not available"Length of output: 652
Implementation does not match PR title: registry remains mosipdev/ instead of mosipdev2/.
The PR title states "[DSD-9246] mosipdev to mosipdev2," but the actual change only updates the image name and tag while leaving the registry prefix unchanged at mosipdev/. The line should reference mosipdev2/apitest-inji-certify:develop develop to align with the stated migration intent.
The format with "develop develop" is correct per file conventions and requires no changes.
🤖 Prompt for AI Agents
In release/vidivi/images.txt around lines 1 to 1 the registry prefix was not
updated: it still reads mosipdev/ while the PR intends to migrate to mosipdev2/.
Update the image reference to use the new registry prefix so the line reads
mosipdev2/apitest-inji-certify:develop develop, keeping the existing "develop
develop" format unchanged.
2 participants
Summary by CodeRabbit