chore(chart): release 9.0.0-beta.10 with the ui_react client_id default - #113
Merged
Conversation
The chart hard-failed to render unless components.ui_react.config.client_id was set, so with the legacy UI now off by default a bare install shipped no frontend at all. Default the client to mint-local, the same client auth.client_id already gives the legacy UI, and enable the component. Move its default ingress to mint.local so the origin matches that client's callback URL; the legacy UI is off, so nothing contends for the host. Gate the legacy UI ingress on components.ui.enabled. It was gated on its own ingress.enabled only, so a default render emitted an Ingress pointing at a Service that no longer exists. Repackaged 9.0.0-beta.9.
feat(ui-react): default client_id to mint-local and enable by default
PR #112 merged into feat/disable-legacy-ui after that branch had already merged to main, so the ui_react client_id default never reached main and 9.0.0-beta.9 shipped without it. Carry the change to main as a new release rather than repackaging beta.9. beta.9 is already published from index.yaml, and one version must not name two different tarballs. Its .tgz and index entry are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maindoes not have the change from #112.#111 merged to
mainat 23:08:55. #112 merged at 23:10:02, intofeat/disable-legacy-ui— a branch that was already merged. The merge commitccc96d1sits on that branch and never reachedmain, so9.0.0-beta.9onmainis the chart without theui_reactclient ID default.This PR carries it to
main.Why a new version instead of repackaging beta.9
9.0.0-beta.9is already inindex.yamlonmainand served from Pages. One version must not name two different tarballs, soreleases/MINT-9.0.0-beta.9.tgzand its index entry are byte-identical tomain. The change ships as9.0.0-beta.10.Content
Identical to #112, plus the version bump.
components.ui_react.config.client_id""(render hard-failed)mint-localcomponents.ui_react.enabledfalsetruecomponents.ui_react.ingress.hosts[0].hostnext.mint.localmint.localPlus:
templates/ingress-ui.yamlnow gates oncomponents.ui.enabled, not only oncomponents.ui.ingress.enabled. Under beta.9 a default render emits an Ingress atmint.localpointing at themint-uiService that beta.9 no longer creates — a 503 at the root host.mint-localis not a new client.auth.client_idalready defaults to it for the legacy UI, and the host moves tomint.localso the origin matches that client's registered callback URL. The legacy UI is off by default, so the two never contend for the host.The
client_id: ""guard stays a render failure.Verification
helm lint: 0 failed.mint.localwithAUTH_CLIENT_ID: "mint-local". No legacy UI resources. No host collision.releases/MINT-9.0.0-beta.9.tgz: no diff againstmain.index.yamllists both beta.9 and beta.10.After merging
mintproject/monorepopins the chart by submodule pointer. It is onb89c35e(beta.8) and needs bumping to this merge commit.