feat(ui-react): default client_id to mint-local and enable by default - #112
Merged
Merged
Conversation
The chart hard-failed to render unless components.ui_react.config.client_id was set, so with the legacy UI now off by default a bare install shipped no frontend at all. Default the client to mint-local, the same client auth.client_id already gives the legacy UI, and enable the component. Move its default ingress to mint.local so the origin matches that client's callback URL; the legacy UI is off, so nothing contends for the host. Gate the legacy UI ingress on components.ui.enabled. It was gated on its own ingress.enabled only, so a default render emitted an Ingress pointing at a Service that no longer exists. Repackaged 9.0.0-beta.9.
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #111. Base is
feat/disable-legacy-ui, so this diff shows only the change on top of it.#111 turns the legacy UI off by default and asks a question in its own body: a bare install then ships no frontend, because
ui_reactis also off. It is off because enabling it needscomponents.ui_react.config.client_id, and the chart hard-fails to render without one.This gives that value a default, and turns the component on.
Changes
components.ui_react.config.client_id""(render hard-failed)mint-localcomponents.ui_react.enabledfalsetruecomponents.ui_react.ingress.hosts[0].hostnext.mint.localmint.localmint-localis not a new client.auth.client_idalready defaults to it for the legacy UI.Why the host moved
The identity provider matches the callback URL exactly.
mint-localis registered againstmint.local. Leaving the React UI onnext.mint.localwould make the new default wrong at the first login.The legacy UI is off by default after #111, so the two never contend for the host. This is the case the chart's own doc comment already describes: the React UI takes over the legacy UI's host and reuses its client. A deployment that wants both at once must move one of them.
A defect in #111
templates/ingress-ui.yamlwas gated oncomponents.ui.ingress.enabledalone. Withcomponents.ui.enabled: false, a default render still emitted an Ingress atmint.localpointing at themint-uiService that was no longer created. That is a 503 at the root host.The template now gates on
components.ui.enabledas well.The guard stays
client_id: ""is still a render failure, not a silent misconfiguration. Only the first sentence of the message changed, from "is required" to "must not be empty".Verification
helm lint: 0 failed.mint.localwithAUTH_CLIENT_ID: "mint-local". No legacy UI resources. No host collision.--set components.ui.enabled=true: legacy UI renders as before.--set components.ui_react.config.client_id="": the guard fires.releases/MINT-9.0.0-beta.9.tgzrepackaged andindex.yamlregenerated withmake release. The twoREADME.mdrows were edited by hand; helm-docs was not available.Before merging
ui_reactis disabled and that a bare install ships no frontend. Update it.dynamo. If the TACC values do not setcomponents.ui_react.ingress.hosts, this change points the React UI at that deployment's legacy UI host.