Fix native modules not being re-initialized on reload - #6159
Conversation
When calling `ReactNativeHost::ReloadInstance()`, `ReactPackageProvider`s are not reiterated and thus not calling `AddAttributedModules()`. As a consequence, the native modules that were loaded the first time the app was loaded, no longer "exist" after a reload.
|
Andrew Coates (@acoates-ms): I hit this issue while trying to figure out why my |
|
Vladimir Morozov (@vmoroz) - Seems good to me but want you to check. This also seems bad. I'm surprised other people haven't hit it. It probably needs backporting? |
|
Andrew Coates (@acoates-ms) instance reload was IIRC very unreliable in MSRN until 0.63. We didn't really hear feedback on it, so I'm kind of curious what development workflow looks like for the average RNW user. |
Andrew Coates (@acoates-ms) - yes, the change is good. We did the same in private repo for the CodePush implementation. Tommy Nguyen (@tido64), thank you for fixing it! |
Vladimir Morozov (vmoroz)
added
the
AutoMerge
|
Hello Vladimir Morozov (@vmoroz)! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 7 hours 36 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Tommy Nguyen (@tido64), please run |
ghost
removed
the
AutoMerge
|
Thanks for the super quick review ❤️ |
Nick Gerleman (NickGerleman)
added
the
AutoMerge
* Fix native modules not being re-initialized on reload When calling `ReactNativeHost::ReloadInstance()`, `ReactPackageProvider`s are not reiterated and thus not calling `AddAttributedModules()`. As a consequence, the native modules that were loaded the first time the app was loaded, no longer "exist" after a reload. * Change files
When calling `ReactNativeHost::ReloadInstance()`, `ReactPackageProvider`s are not reiterated and thus not calling `AddAttributedModules()`. As a consequence, the native modules that were loaded the first time the app was loaded, no longer "exist" after a reload.
When calling `ReactNativeHost::ReloadInstance()`, `ReactPackageProvider`s are not reiterated and thus not calling `AddAttributedModules()`. As a consequence, the native modules that were loaded the first time the app was loaded, no longer "exist" after a reload.
When calling `ReactNativeHost::ReloadInstance()`, `ReactPackageProvider`s are not reiterated and thus not calling `AddAttributedModules()`. As a consequence, the native modules that were loaded the first time the app was loaded, no longer "exist" after a reload.
When calling `ReactNativeHost::ReloadInstance()`, `ReactPackageProvider`s are not reiterated and thus not calling `AddAttributedModules()`. As a consequence, the native modules that were loaded the first time the app was loaded, no longer "exist" after a reload.
When calling `ReactNativeHost::ReloadInstance()`, `ReactPackageProvider`s are not reiterated and thus not calling `AddAttributedModules()`. As a consequence, the native modules that were loaded the first time the app was loaded, no longer "exist" after a reload.
4 participants
When calling
ReactNativeHost::ReloadInstance(),ReactPackageProviders are not reiterated and thus not callingAddAttributedModules(). As a consequence, the native modules that were loaded the first time the app was loaded, no longer "exist" after a reload.Microsoft Reviewers: Open in CodeFlow