fix(Windows): Debug settings are not persisted across sessions - #212
Merged
Conversation
Tommy Nguyen (tido64)
force-pushed
the
tido/rn-62
branch
2 times, most recently
from
September 5, 2020 21:45
e76d332 to
882187f
Compare
Tommy Nguyen (tido64)
force-pushed
the
tido/windows-debug-menu
branch
from
September 5, 2020 22:16
d99fea1 to
8a7a3f0
Compare
Tommy Nguyen (tido64)
force-pushed
the
tido/windows-debug-menu
branch
from
September 7, 2020 09:34
8a7a3f0 to
865f5b2
Compare
Tommy Nguyen (tido64)
force-pushed
the
tido/windows-debug-menu
branch
from
September 23, 2020 20:33
865f5b2 to
a02acd6
Compare
Tommy Nguyen (tido64)
force-pushed
the
tido/windows-debug-menu
branch
from
October 1, 2020 17:29
0b7ad76 to
4eb560a
Compare
Tommy Nguyen (tido64)
force-pushed
the
tido/windows-debug-menu
branch
7 times, most recently
from
October 4, 2020 17:08
42a0cbf to
9e16367
Compare
Tommy Nguyen (tido64)
force-pushed
the
tido/windows-debug-menu
branch
2 times, most recently
from
October 8, 2020 11:54
9da9a96 to
a2364ac
Compare
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 12, 2020 16:56
Tommy Nguyen (tido64)
requested review from
Araz Abishov (arazabishov) and
Sam Mathias Weggersen (sweggersen)
October 12, 2020 16:56
Tommy Nguyen (tido64)
force-pushed
the
tido/windows-debug-menu
branch
3 times, most recently
from
October 13, 2020 00:31
45a8294 to
6558cff
Compare
Lorenzo Sciandra (kelset)
self-requested a review
October 16, 2020 12:03
Tommy Nguyen (tido64)
force-pushed
the
tido/windows-debug-menu
branch
from
October 16, 2020 15:13
6558cff to
d9e54bf
Compare
Lorenzo Sciandra (kelset)
approved these changes
Oct 16, 2020
Member
Author
Member
Author
|
🎉 This PR is included in version 0.2.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


To Do
DevSettingsmodule is not initialized after reload (Fix native modules not being re-initialized on reload react-native-windows#6159)Test Plan
Ctrl+Shift+Dshould openreact-native-windows' developer menugit clean -dfqxto restore statereact-nativeto ^0.63 andreact-native-windowsto ^0.63.5 (see diff below)Ctrl+Shift+Dshould open it instead ofreact-native-windows' developer menuToggle Inspectorshould always work, even after a JS reload