Skip to content

fix(Windows): Debug settings are not persisted across sessions - #212

Merged
Tommy Nguyen (tido64) merged 2 commits into
masterfrom
tido/windows-debug-menu
Oct 16, 2020
Merged

fix(Windows): Debug settings are not persisted across sessions#212
Tommy Nguyen (tido64) merged 2 commits into
masterfrom
tido/windows-debug-menu

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Sep 5, 2020

Copy link
Copy Markdown
Member
Normal With Access Keys
image image
image image

To Do

Test Plan

  1. Build and run Windows test app
  2. The debug menu should be disabled
    • Ctrl+Shift+D should open react-native-windows' developer menu
  3. Run git clean -dfqx to restore state
  4. Bump react-native to ^0.63 and react-native-windows to ^0.63.5 (see diff below)
  5. Build and run Windows test app
  6. The debug menu should be enabled
    • Ctrl+Shift+D should open it instead of react-native-windows' developer menu
    • The state of each item in the debug menu should be restored when the app is restarted
    • Toggle Inspector should always work, even after a JS reload
diff --git a/example/package.json b/example/package.json
index 5bde75f..2d7104d 100644
--- a/example/package.json
+++ b/example/package.json
@@ -25,10 +25,9 @@
   "devDependencies": {
     "@babel/core": "^7.0.0",
     "mkdirp": "^0.5.1",
-    "react": "16.11.0",
-    "react-native": "0.62.2",
-    "react-native-macos": "0.62.14",
+    "react": "16.13.1",
+    "react-native": "0.63.3",
     "react-native-test-app": "../",
-    "react-native-windows": "0.62.12"
+    "react-native-windows": "0.63.5"
   }
 }

Comment thread windows/ReactTestApp/ReactInstance.cpp Outdated
@tido64
Tommy Nguyen (tido64) force-pushed the tido/windows-debug-menu branch 2 times, most recently from 9da9a96 to a2364ac Compare October 8, 2020 11:54
@tido64
Tommy Nguyen (tido64) marked this pull request as ready for review October 12, 2020 16:56
@tido64
Tommy Nguyen (tido64) force-pushed the tido/windows-debug-menu branch 3 times, most recently from 45a8294 to 6558cff Compare October 13, 2020 00:31

@kelset Lorenzo Sciandra (kelset) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, talked with Tommy about it and walked through the main code changes - so only one thing left to do:

@tido64

Copy link
Copy Markdown
Member Author

@tido64
Tommy Nguyen (tido64) merged commit c943788 into master Oct 16, 2020
@tido64
Tommy Nguyen (tido64) deleted the tido/windows-debug-menu branch October 16, 2020 15:55
@tido64

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 0.2.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Windows This affects Windows released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants