Skip to content

Add --autogenerateVersionNumber flag for canary version in publish.yml - #995

Merged
Adam Gleitman (amgleitman) merged 1 commit into
microsoft:0.66-stablefrom
amgleitman:amgleitman/publish-yml-autogenerate-canary-version-number
Jan 27, 2022
Merged

Add --autogenerateVersionNumber flag for canary version in publish.yml#995
Adam Gleitman (amgleitman) merged 1 commit into
microsoft:0.66-stablefrom
amgleitman:amgleitman/publish-yml-autogenerate-canary-version-number

Conversation

@amgleitman

Copy link
Copy Markdown

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Add the --autogenerateVersionNumber flag for the bump-oss-version.js invocation in publish.yml.

This new flag was introduced with #989. While this ADO task won't get run in a non-main branch, we're still making it here for the sake of correctness.

@Saadnajmi

Copy link
Copy Markdown
Collaborator

We don't need the Android changes in #989 to fix the CI here?

@amgleitman

Copy link
Copy Markdown
Author

We don't need the Android changes in #989 to fix the CI here?

This is going into 0.66-stable, where #989 has already been applied. We'll be bringing these into main at a later date.

@Saadnajmi

Copy link
Copy Markdown
Collaborator

We don't need the Android changes in #989 to fix the CI here?

This is going into 0.66-stable, where #989 has already been applied. We'll be bringing these into main at a later date.

Ah, thought this was the one going to main my bad!

@amgleitman
Adam Gleitman (amgleitman) merged commit 94527a1 into microsoft:0.66-stable Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants