Skip to content

Add --autogenerateVersionNumber option to bump-oss-version.js - #989

Merged
HeyImChris merged 2 commits into
microsoft:0.66-stablefrom
amgleitman:amgleitman/bump-oss-version-autogenerate-version-number
Jan 26, 2022
Merged

Add --autogenerateVersionNumber option to bump-oss-version.js#989
HeyImChris merged 2 commits into
microsoft:0.66-stablefrom
amgleitman:amgleitman/bump-oss-version-autogenerate-version-number

Conversation

@amgleitman

Copy link
Copy Markdown

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Add an --autogenerateVersionNumber flag to scripts/bump-oss-version.js.

Some CI checks have been failing due to a change in this script. We still have some old invocations that assume the script will generate an ad-hoc version number. This change helps make the transition easier. If we so desire, we can change our CI scripts as needed in the future.

@acoates-ms

Copy link
Copy Markdown

Can we just use the nightly flag for this?

@amgleitman

Copy link
Copy Markdown
Author

Can we just use the nightly flag for this?

Possibly, but I figure that adding a separate flag shows a clearer distinction between us and upstream.

@acoates-ms

Copy link
Copy Markdown

Ok, Then make sure to update the use of this script in the publish.yml when porting this to the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants