Repository navigation
feat(ui mode): add a "not run" status filter - #43441
Closed
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Closed
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Yury Semikhatsky (yury-s) wants to merge 1 commit into
Conversation
Tests without a result already have the "none" status in the test tree, and interrupted results map back to it. Expose it as a fourth status checkbox labeled "not run", so that after a partial run the tree can be narrowed to the tests that still need to run. Fixes: #43434
Yury Semikhatsky (yury-s)
marked this pull request as ready for review
October 15, 2026 22:43
Contributor
Test results for "tests 1"3 flaky23559 passed, 710 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 5153 passed, 614 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🟢 The failure is a confirmed pre-existing flakeThe only real failure is unrelated to this PR, so the PR is clear. DetailsThis PR changes UI Mode status filtering and its test. It does not reach the MCP WebMCP code path that failed. The other three reported tests passed on retry and do not need triage. Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests without a result already have the
nonestatus in the test tree, and interrupted results map back to it. This exposes it as a fourth Status checkbox labeled not run, next to passed, failed and skipped. The filter key staysnone, soTestTree.filterTreeworks unchanged; only the checkbox and the summary line show the label. The UI Mode guide mentions the new filter.The status filter test now runs one file first and checks that not run narrows the tree to the other file's tests, then continues with the existing passed/failed checks.
Fixes: #43434