Skip to content

feat(firefox): roll to r1560 - #43369

Merged
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-firefox/1560
Oct 14, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-firefox/1560

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/00ad3465fcaa2eab9cbc45bb59a21844258c203e. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 flaky ⚠️ [chromium-library] › library/video.spec.ts:690 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

53526 passed, 1267 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/launch.spec.ts:96 › persistent context @mcp-macos-latest-chrome
❌ [chrome] › mcp/webmcp-dynamic.spec.ts:189 › a tool registered in an iframe can be called after the page is reloaded @mcp-ubuntu-latest-chrome
❌ [firefox] › mcp/cli-core.spec.ts:57 › click link @mcp-windows-latest-firefox

9201 passed, 1495 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟡 The failures do not look caused by this PR, but one remains uncertain

Two MCP tests are confirmed pre-existing flakes. The remaining Chrome timeout is outside this Firefox-only change, but there is no matching failure on an unrelated SHA, so it is uncertain under the CI triage rules.

Details

This PR changes the Firefox browser revision and Firefox-specific patches. The tests 1 report has no final failures; all three reported flakes passed on retry.

Pre-existing flake / infra

  • [firefox] › mcp/cli-core.spec.ts:57 › click link on Windows — this exact test and bot combination failed on 7 of 81 recent runs and passed 74. The failures include unrelated main runs such as 38470001570, before this PR. Although the Firefox roll can reach this test, its cross-run history confirms that it already flakes.
  • [chrome] › mcp/webmcp-dynamic.spec.ts:189 › a tool registered in an iframe can be called after the page is reloaded on Ubuntu — the current Tool "webmcp_add" not found error also occurred on unrelated main runs 38284917185 and 38284286251. This test failed on 3 of 82 recent runs and passed 79; the Firefox-only diff does not reach Chrome.

Uncertain

  • [chrome] › mcp/launch.spec.ts:96 › persistent context on macOS — the test timed out with MCP error -32000: Connection closed. The Firefox-only diff does not reach Chrome, so this does not look caused by the PR. However, this is its only failure in 82 recent runs, so there is no same-test failure on an unrelated SHA to confirm a pre-existing flake. A matching failure on main or another unrelated SHA would settle it.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

3 failed
❌ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › should update aria snapshot highlight @firefox-macos-15-large
❌ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies @firefox-macos-15-xlarge
❌ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe @firefox-macos-15-xlarge

33 flaky ⚠️ [chromium-library] › library/webmcp.spec.ts:238 › should call same-name tools in their own frame `@tracing-chromium`
⚠️ [chromium-page] › page/page-screenshot.spec.ts:509 › page screenshot › should take fullPage screenshots during navigation `@tracing-chromium`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:117 › should connect when an existing page has been discarded `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1717 › should highlight locator in iframe while typing `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1937 › should not leak recorders `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/har.spec.ts:109 › should populate entry startedDateTime from the browser `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › should print context options method override in xunit if options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-python-async.spec.ts:80 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-test.spec.ts:20 › should print the correct imports and context options `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browser.spec.ts:54 › should dispatch page.on(close) upon browser.close and reject evaluate `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/channels.spec.ts:40 › should scope context handles `@firefox-windows-latest`
⚠️ [firefox-library] › library/proxy.spec.ts:125 › should allow bypassing 127.0.0.1 requests `@firefox-windows-latest`
⚠️ [firefox-library] › library/signals.spec.ts:25 › should close the browser when the node process closes `@firefox-windows-latest`
⚠️ [firefox-library] › library/defaultbrowsercontext-1.spec.ts:89 › should support viewport option `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1717 › should highlight locator in iframe while typing `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:2009 › canvas disabled title `@webkit-macos-15-xlarge`
⚠️ [android-native] › android/browser.spec.ts:33 › androidDevice.launchBrowser should treat args correctly

115059 passed, 4912 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the latest CI failures.

🟢 All failures are confirmed pre-existing flakes

None of the three final failures in the latest report looks caused by this Firefox roll. Each exact test has failed on unrelated SHAs and passed most other recent runs.

Details

This PR updates the Firefox revision and Firefox-specific patches. The other 33 tests in the report passed on retry and do not need triage.

Pre-existing flake / infra

  • [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › should update aria snapshot highlight on macOS — the highlight was not found after four attempts. This exact test failed on 18 of 114 recent runs and passed 96, including a failure on the same macOS bot in unrelated main run 38289566014.
  • [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies and :470 › top level 'Partitioned;' cookie and same origin iframe on macOS — the expected partitioned cookie was absent. The exact tests failed on 5 of 114 and 7 of 114 recent runs respectively, while passing the others. Matching failures occurred on unrelated main runs 38466762300 and 38311530574.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit ccd519e into main Oct 14, 2026
@dgozman
Dmitry Gozman (dgozman) deleted the roll-into-pw-firefox/1560 branch October 14, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant