Skip to content

[test] Intrinsics with colon no longer type-checked - #53784

Closed
Sebastian "Sebbie" Silbermann (eps1lon) wants to merge 4 commits into
microsoft:mainfrom
eps1lon:fix/jsx-element-types/colon
Closed

[test] Intrinsics with colon no longer type-checked#53784
Sebastian "Sebbie" Silbermann (eps1lon) wants to merge 4 commits into
microsoft:mainfrom
eps1lon:fix/jsx-element-types/colon

Conversation

@eps1lon

@eps1lon Sebastian "Sebbie" Silbermann (eps1lon) commented Apr 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

types/fbt is currently broken in 5.1.0-dev.20230415

Broke in #47356

I'm not sure yet whether this was caused by #51328 or #53284.

Considering #53284 because the hovering with the cursor treats the parts before and after the colon as separate types:
5.0:

Screenshot from 2023-04-15 10-26-01

5.1:

Screenshot from 2023-04-15 10-27-06
Screenshot from 2023-04-15 10-27-02

@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 15, 2023
Merged
eps1lon
Sebastian "Sebbie" Silbermann (eps1lon) commented Apr 15, 2023
View reviewed changes
Comment thread tests/baselines/reference/jsxElementType.errors.txt
declare global {
namespace JSX {
interface IntrinsicElements {
['fbt:enum']: { knownProp: string };

@eps1lon Sebastian "Sebbie" Silbermann (eps1lon) Apr 15, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this needs to be declared another way now that #47356 has landed? But even if we drop support for that, the error message currently produced is not helpful. It silently treats <fbt:enum /> as any.

@eps1lon
Sebastian "Sebbie" Silbermann (eps1lon) marked this pull request as ready for review April 15, 2023 09:10
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 15, 2023

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Apr 15, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) cherry-pick this to revert-47356-feat/7411

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into revert-47356-feat/7411 on this PR at 9e4bfaf. You can monitor the build here.

Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 15, 2023

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #53793 for you.

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request Apr 15, 2023
@eps1lon @typescript-bot
Cherry-pick PR microsoft#53784 into revert-47356-feat/7411
f82f2e0 
Component commits:
d61ffe1 [test] Intrinsics with colon no longer type-checked

3f81077 f

a4e76fd f

9e4bfaf f
Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Apr 15, 2023
TypeScript Bot @eps1lon
🤖 Pick PR #53784 ([test] Intrinsics with colon no lon...) into revert…
a674d0b 
…-47356-feat/7411 (#53793)

Co-authored-by: eps1lon <silbermann.sebastian@gmail.com>
@a-tarasyuk

Oleksandr Tarasiuk (a-tarasyuk) commented Apr 16, 2023

Copy link
Copy Markdown
Contributor

Sebastian "Sebbie" Silbermann (@eps1lon) Thank you for taking the time to immediately test the latest changes and identify the new important edge case. I've created a new pull request #53799 that fixes the bug.

Daniel Rosenwasser (@DanielRosenwasser) I noticed that you opened a PR to revert the changes. Would you like me to create a new PR after merging the revert into the main branch?

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Apr 16, 2023

Copy link
Copy Markdown
Member

Yeah I just wanted to see if the behavior was changed. If we can get in your fix (just apply my test suggestions, update baselines, and take the PR out of draft state) then I think I can bring it into the TS 5.1 beta.

@eps1lon

Sebastian "Sebbie" Silbermann (eps1lon) commented Apr 17, 2023

Copy link
Copy Markdown
Contributor Author

Fixed in #53799

@eps1lon
Sebastian "Sebbie" Silbermann (eps1lon) deleted the fix/jsx-element-types/colon branch April 17, 2023 07:26
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eps1lon @typescript-bot @DanielRosenwasser @a-tarasyuk