feat(7411): JSX namespaced attribute syntax not supported by a-tarasyuk · Pull Request #47356 · microsoft/TypeScript

Oleksandr Tarasiuk (a-tarasyuk) · 2022-01-09T11:51:36Z

JSXElementName:
 - JSXIdentifier
 - JSXNamespacedName
 - JSXMemberExpression

JSXAttributeName:
 - JSXIdentifier
 - JSXNamespacedName

JSXNamespacedName:
 - JSXIdentifier : JSXIdentifier

TypeScript Bot (typescript-bot) · 2022-01-10T20:05:00Z

The TypeScript team hasn't accepted the linked issue #7411. If you can get it accepted, this PR will have a better chance of being reviewed.

Wesley Wigham (weswigham)

Can we get tests with more variety of odd namespace names in both tag name and property name positions? Like Component:foo or some-thing:bar? Specifically, in the case of the first one, I'd like to know if it tries to somehow lookup a Component:foo local variable (which'd be odd) for the type of the tag. (You could technically make this with an assignment to globalThis["Component:foo"], except the lookup for the tag probably has no shot of resolving at runtime - do namespaced custom tags even work?) which I'm down with just looking up intrinsics named svg:path and so on and props named ns:prop and so on, so that part of the checking seems fine. But do we need errors when a react-ish emit mode is set? react doesn't use namespaces as far as I'm aware. Maybe this should be flagged in some way because of that? (it's flagged in babel afaik)

Additionally, ping Ryan Cavanaugh (@RyanCavanaugh) for the go/no go on this; we didn't want em for a long time, but I guess some framework (vue2?) uses the namespace syntax now, even though you have to silence an error in babel to use it.

Oleksandr Tarasiuk (a-tarasyuk) · 2022-03-07T18:07:06Z

Wesley Wigham (@weswigham) Thanks for the review.

Can we get tests with more variety of odd namespace names in both tag name and property name positions? Like Component:foo or some-thing:bar?

I'm not sure I fully understood the requested changes. Do you mean something like this? Or do you mean that I need to define global types to check name resolution?

// @jsx: preserve
// @filename: a.tsx

<A:foo></A:foo>;

Could you provide some examples that I can use as tests?

Wesley Wigham (weswigham) · 2022-03-07T18:32:35Z

Do you mean something like this?

Yeah, with both capital-letter-starting and dash-containing names. (The first being an indication of function components and the later indicating non-identifier builtins). For checking intrinsics, adding namespaced dashed names to intrinsic tag names should be fine. For the capital-letter variant, I don't think there's any reasonable way to check it or even transpile it, after all React.createElement(Component:foo) is obviously invalid syntax, so it probably needs to be an error.

Oleksandr Tarasiuk (a-tarasyuk) · 2022-03-07T18:39:31Z

For the capital-letter variant, I don't think there's any reasonable way to check it or even transpile it, after all React.createElement(Component:foo) is obviously invalid syntax, so it probably needs to be an error.

Shouldn't we transpile it as React.createElement("Component:foo")? Some bundles just emit it as React.createElement("Component:foo")

Wesley Wigham (weswigham) · 2022-03-07T19:18:27Z

No - only intrinsic names do that, and only names starting with a lower case character are intrinsic names.

Oleksandr Tarasiuk (a-tarasyuk) · 2022-03-07T19:34:46Z

Wesley Wigham (@weswigham) Oke. Should TS parse it as JSXNamespacedName and throw an error in the checker? Or at the parser stage?

Wesley Wigham (weswigham) · 2022-03-07T19:50:31Z

Mmmm, checker is better for error recovery, usually.

Oleksandr Tarasiuk (a-tarasyuk) · 2022-06-24T14:55:27Z

Additionally, ping Ryan Cavanaugh (@RyanCavanaugh) for the go/no go on this; we didn't want em for a long time, but I guess some framework (vue2?) uses the namespace syntax now, even though you have to silence an error in babel to use it.

Ryan Cavanaugh (@RyanCavanaugh) What do you think about JSXNamespacedName support?

…eat/7411

Wesley Wigham (weswigham)

This looks OK to me, but I'm going to kick it over to Ryan Cavanaugh (@RyanCavanaugh) for final approval and merging after community tests have come back, since it's up to him if this much support for namespace names is actually what we wanted (or if we just wanted better parser recovery).

Wesley Wigham (weswigham) · 2023-03-20T19:54:42Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-03-20T19:54:45Z

Heya Wesley Wigham (@weswigham), I've started to run the diff-based top-repos suite on this PR at 23379dd. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-20T19:54:45Z

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at 23379dd. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-20T19:54:45Z

Heya Wesley Wigham (@weswigham), I've started to run the perf test suite on this PR at 23379dd. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-20T19:54:45Z

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at 23379dd. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-03-20T19:54:45Z

Heya Wesley Wigham (@weswigham), I've started to run the tarball bundle task on this PR at 23379dd. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-03-20T19:56:51Z

Hey Wesley Wigham (@weswigham), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/150274/artifacts?artifactName=tgz&fileId=AE5479640F8658C66EE2CB5865EE83E8322E764552171451F22E07134C18045802&fileName=/typescript-5.1.0-insiders.20230320.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-47356-14".;

TypeScript Bot (typescript-bot) · 2023-03-20T21:50:17Z

Wesley Wigham (@weswigham) Here are the results of running the top-repos suite comparing main and refs/pull/47356/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-03-20T21:55:47Z

Hey Wesley Wigham (@weswigham), the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: fbt
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/fbt/fbt-tests.tsx:406:13
ERROR: 406:13  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 416:13  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 427:13  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 433:1   expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 458:10  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 465:10  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 527:13  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 537:13  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 548:13  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 554:1   expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

TypeScript Bot (typescript-bot) · 2023-03-21T16:35:45Z

Wesley Wigham (@weswigham)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..47356

_Metric	_main	₄₇₃₅₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{361,721k (± 0.01%)}	_{361,709k (± 0.01%)}	_~	_361,684k	_361,730k	_{p=0.335 n=6}
_{Parse Time}	_{3.38s (± 0.61%)}	_{3.39s (± 0.40%)}	_~	_3.37s	_3.41s	_{p=0.317 n=6}
_{Bind Time}	_{1.12s (± 1.08%)}	_{1.12s (± 0.49%)}	_~	_1.11s	_1.12s	_{p=0.855 n=6}
_{Check Time}	_{8.67s (± 0.38%)}	_{8.70s (± 0.34%)}	_~	_8.66s	_8.74s	_{p=0.169 n=6}
_{Emit Time}	_{7.44s (± 0.69%)}	_{7.45s (± 0.77%)}	_~	_7.38s	_7.53s	_{p=0.687 n=6}
_{Total Time}	_{20.60s (± 0.35%)}	_{20.66s (± 0.45%)}	_~	_20.51s	_20.76s	_{p=0.296 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,677k (± 1.53%)}	_{192,835k (± 1.54%)}	_~	_190,893k	_196,779k	_{p=0.173 n=6}
_{Parse Time}	_{1.49s (± 1.82%)}	_{1.52s (± 0.99%)}	_~	_1.50s	_1.53s	_{p=0.099 n=6}
_{Bind Time}	_{0.77s (± 0.00%)}	_{0.77s (± 0.82%)}	_~	_0.76s	_0.78s	_{p=1.000 n=6}
_{Check Time}	_{9.44s (± 0.86%)}	_{9.49s (± 0.65%)}	_~	_9.38s	_9.54s	_{p=0.229 n=6}
_{Emit Time}	_{2.73s (± 1.33%)}	_{2.73s (± 0.79%)}	_~	_2.70s	_2.76s	_{p=0.808 n=6}
_{Total Time}	_{14.42s (± 0.70%)}	_{14.50s (± 0.61%)}	_~	_14.37s	_14.60s	_{p=0.228 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,260k (± 0.01%)}	_{346,316k (± 0.01%)}	_{+56k (+ 0.02%)}	_346,253k	_346,372k	_{p=0.045 n=6}
_{Parse Time}	_{2.59s (± 0.97%)}	_{2.61s (± 0.80%)}	_~	_2.59s	_2.64s	_{p=0.090 n=6}
_{Bind Time}	_{1.01s (± 1.02%)}	_{1.01s (± 0.40%)}	_~	_1.01s	_1.02s	_{p=0.268 n=6}
_{Check Time}	_{7.03s (± 0.62%)}	_{7.06s (± 0.50%)}	_~	_7.02s	_7.10s	_{p=0.293 n=6}
_{Emit Time}	_{4.24s (± 1.18%)}	_{4.26s (± 0.74%)}	_~	_4.22s	_4.31s	_{p=0.469 n=6}
_{Total Time}	_{14.87s (± 0.69%)}	_{14.95s (± 0.51%)}	_~	_14.87s	_15.07s	_{p=0.126 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,459k (± 0.01%)}	_{300,459k (± 0.01%)}	_~	_300,420k	_300,487k	_{p=0.936 n=6}
_{Parse Time}	_{2.06s (± 1.09%)}	_{2.09s (± 1.19%)}	_{+0.04s (+ 1.78%)}	_2.07s	_2.13s	_{p=0.038 n=6}
_{Bind Time}	_{1.14s (± 0.86%)}	_{1.14s (± 0.91%)}	_~	_1.12s	_1.15s	_{p=0.591 n=6}
_{Check Time}	_{6.52s (± 0.50%)}	_{6.53s (± 0.31%)}	_~	_6.50s	_6.56s	_{p=0.686 n=6}
_{Emit Time}	_{3.88s (± 0.45%)}	_{3.88s (± 0.72%)}	_~	_3.84s	_3.92s	_{p=1.000 n=6}
_{Total Time}	_{13.61s (± 0.36%)}	_{13.64s (± 0.20%)}	_~	_13.60s	_13.67s	_{p=0.260 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{477,159k (± 0.01%)}	_{477,152k (± 0.01%)}	_~	_477,110k	_477,186k	_{p=1.000 n=6}
_{Parse Time}	_{2.99s (± 2.16%)}	_{3.02s (± 2.63%)}	_~	_2.93s	_3.10s	_{p=0.513 n=6}
_{Bind Time}	_{0.99s (± 8.57%)}	_{0.99s (± 9.07%)}	_~	_0.90s	_1.08s	_{p=0.935 n=6}
_{Check Time}	_{16.93s (± 0.46%)}	_{16.93s (± 0.68%)}	_~	_16.81s	_17.12s	_{p=0.935 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.90s (± 0.40%)}	_{20.93s (± 0.54%)}	_~	_20.84s	_21.13s	_{p=0.936 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{552,968k (± 0.02%)}	_{552,908k (± 0.01%)}	_~	_552,878k	_552,959k	_{p=0.378 n=6}
_{Parse Time}	_{3.77s (± 0.83%)}	_{3.81s (± 0.27%)}	_~	_3.80s	_3.83s	_{p=0.052 n=6}
_{Bind Time}	_{1.70s (± 0.53%)}	_{1.71s (± 0.60%)}	_~	_1.70s	_1.73s	_{p=0.054 n=6}
_{Check Time}	_{2.74s (± 0.85%)}	_{2.76s (± 0.54%)}	_~	_2.75s	_2.78s	_{p=0.101 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.31s (± 0.39%)}	_{8.38s (± 0.27%)}	_{+0.07s (+ 0.82%)}	_8.36s	_8.42s	_{p=0.005 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,038k (± 0.01%)}	_{361,021k (± 0.01%)}	_~	_360,984k	_361,051k	_{p=0.471 n=6}
_{Parse Time}	_{3.52s (± 0.21%)}	_{3.55s (± 0.81%)}	_{+0.04s (+ 1.04%)}	_3.52s	_3.59s	_{p=0.018 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.44%)}	_~	_1.18s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.50s (± 0.57%)}	_{9.49s (± 0.43%)}	_~	_9.44s	_9.55s	_{p=0.872 n=6}
_{Emit Time}	_{7.94s (± 0.62%)}	_{7.97s (± 1.17%)}	_~	_7.86s	_8.13s	_{p=0.630 n=6}
_{Total Time}	_{22.14s (± 0.30%)}	_{22.20s (± 0.50%)}	_~	_22.07s	_22.40s	_{p=0.470 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,705k (± 0.89%)}	_{193,604k (± 0.85%)}	_~	_192,533k	_195,800k	_{p=0.378 n=6}
_{Parse Time}	_{1.58s (± 1.01%)}	_{1.60s (± 1.36%)}	_~	_1.56s	_1.62s	_{p=0.191 n=6}
_{Bind Time}	_{0.82s (± 1.27%)}	_{0.83s (± 0.49%)}	_~	_0.82s	_0.83s	_{p=0.528 n=6}
_{Check Time}	_{10.11s (± 0.57%)}	_{10.24s (± 0.63%)}	_{+0.13s (+ 1.32%)}	_10.18s	_10.32s	_{p=0.016 n=6}
_{Emit Time}	_{2.98s (± 0.55%)}	_{2.98s (± 0.54%)}	_~	_2.96s	_3.00s	_{p=0.737 n=6}
_{Total Time}	_{15.49s (± 0.35%)}	_{15.65s (± 0.44%)}	_{+0.15s (+ 0.99%)}	_15.57s	_15.73s	_{p=0.008 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,561k (± 0.00%)}	_{345,541k (± 0.00%)}	_{-20k (- 0.01%)}	_345,532k	_345,555k	_{p=0.013 n=6}
_{Parse Time}	_{2.73s (± 0.55%)}	_{2.75s (± 0.78%)}	_~	_2.73s	_2.78s	_{p=0.157 n=6}
_{Bind Time}	_{1.09s (± 0.96%)}	_{1.09s (± 0.69%)}	_~	_1.08s	_1.10s	_{p=0.273 n=6}
_{Check Time}	_{7.73s (± 0.54%)}	_{7.73s (± 0.61%)}	_~	_7.66s	_7.79s	_{p=1.000 n=6}
_{Emit Time}	_{4.47s (± 0.28%)}	_{4.48s (± 0.92%)}	_~	_4.43s	_4.55s	_{p=0.870 n=6}
_{Total Time}	_{16.02s (± 0.36%)}	_{16.05s (± 0.61%)}	_~	_15.92s	_16.21s	_{p=0.809 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,817k (± 0.01%)}	_{299,794k (± 0.01%)}	_~	_299,765k	_299,824k	_{p=0.378 n=6}
_{Parse Time}	_{2.18s (± 0.95%)}	_{2.17s (± 0.75%)}	_~	_2.15s	_2.19s	_{p=0.745 n=6}
_{Bind Time}	_{1.24s (± 1.10%)}	_{1.24s (± 0.97%)}	_~	_1.23s	_1.26s	_{p=1.000 n=6}
_{Check Time}	_{7.18s (± 0.38%)}	_{7.22s (± 0.53%)}	_~	_7.16s	_7.25s	_{p=0.147 n=6}
_{Emit Time}	_{4.34s (± 0.86%)}	_{4.36s (± 0.82%)}	_~	_4.31s	_4.41s	_{p=0.519 n=6}
_{Total Time}	_{14.95s (± 0.51%)}	_{14.99s (± 0.52%)}	_~	_14.88s	_15.08s	_{p=0.336 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,401k (± 0.00%)}	_{476,465k (± 0.01%)}	_{+65k (+ 0.01%)}	_476,396k	_476,557k	_{p=0.020 n=6}
_{Parse Time}	_{3.21s (± 0.42%)}	_{3.21s (± 1.10%)}	_~	_3.15s	_3.24s	_{p=0.933 n=6}
_{Bind Time}	_{0.96s (± 0.54%)}	_{0.97s (± 1.80%)}	_{+0.02s (+ 1.74%)}	_0.96s	_1.00s	_{p=0.040 n=6}
_{Check Time}	_{18.01s (± 0.70%)}	_{18.02s (± 0.40%)}	_~	_17.96s	_18.15s	_{p=0.686 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.18s (± 0.65%)}	_{22.21s (± 0.32%)}	_~	_22.15s	_22.34s	_{p=0.419 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,557k (± 0.02%)}	_{550,631k (± 0.03%)}	_~	_550,519k	_550,887k	_{p=0.336 n=6}
_{Parse Time}	_{3.95s (± 0.46%)}	_{3.97s (± 0.49%)}	_~	_3.95s	_4.00s	_{p=0.062 n=6}
_{Bind Time}	_{1.80s (± 0.45%)}	_{1.79s (± 0.67%)}	_~	_1.78s	_1.81s	_{p=0.677 n=6}
_{Check Time}	_{2.99s (± 0.82%)}	_{2.98s (± 0.81%)}	_~	_2.96s	_3.03s	_{p=0.869 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.83s (± 0.35%)}	_{8.84s (± 0.43%)}	_~	_8.80s	_8.90s	_{p=0.629 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{354,900k (± 0.01%)}	_{354,926k (± 0.01%)}	_~	_354,889k	_354,978k	_{p=0.173 n=6}
_{Parse Time}	_{3.59s (± 0.63%)}	_{3.64s (± 0.79%)}	_{+0.05s (+ 1.39%)}	_3.61s	_3.69s	_{p=0.012 n=6}
_{Bind Time}	_{1.23s (± 0.84%)}	_{1.23s (± 0.42%)}	_~	_1.23s	_1.24s	_{p=0.928 n=6}
_{Check Time}	_{9.81s (± 0.40%)}	_{9.84s (± 0.36%)}	_~	_9.78s	_9.88s	_{p=0.126 n=6}
_{Emit Time}	_{8.38s (± 0.63%)}	_{8.43s (± 0.97%)}	_~	_8.31s	_8.51s	_{p=0.335 n=6}
_{Total Time}	_{23.01s (± 0.26%)}	_{23.14s (± 0.50%)}	_~	_22.96s	_23.29s	_{p=0.065 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{187,774k (± 0.02%)}	_{187,649k (± 0.08%)}	_~	_187,471k	_187,799k	_{p=0.336 n=6}
_{Parse Time}	_{1.59s (± 0.77%)}	_{1.61s (± 0.61%)}	_{+0.02s (+ 1.04%)}	_1.60s	_1.63s	_{p=0.027 n=6}
_{Bind Time}	_{0.85s (± 0.61%)}	_{0.85s (± 0.60%)}	_~	_0.85s	_0.86s	_{p=0.069 n=6}
_{Check Time}	_{10.29s (± 0.40%)}	_{10.29s (± 0.47%)}	_~	_10.24s	_10.38s	_{p=0.936 n=6}
_{Emit Time}	_{3.13s (± 0.82%)}	_{3.32s (± 6.23%)}	_~	_3.12s	_3.58s	_{p=0.076 n=6}
_{Total Time}	_{15.86s (± 0.32%)}	_{16.07s (± 1.51%)}	_~	_15.83s	_16.37s	_{p=0.226 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{340,548k (± 0.01%)}	_{340,539k (± 0.01%)}	_~	_340,517k	_340,573k	_{p=0.521 n=6}
_{Parse Time}	_{2.83s (± 0.57%)}	_{2.85s (± 0.57%)}	_~	_2.82s	_2.87s	_{p=0.182 n=6}
_{Bind Time}	_{1.10s (± 0.68%)}	_{1.10s (± 0.47%)}	_~	_1.10s	_1.11s	_{p=0.241 n=6}
_{Check Time}	_{8.08s (± 0.33%)}	_{8.10s (± 0.34%)}	_~	_8.08s	_8.15s	_{p=0.225 n=6}
_{Emit Time}	_{4.70s (± 1.16%)}	_{4.70s (± 0.77%)}	_~	_4.64s	_4.74s	_{p=1.000 n=6}
_{Total Time}	_{16.71s (± 0.52%)}	_{16.75s (± 0.26%)}	_~	_16.70s	_16.80s	_{p=0.260 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,888k (± 0.00%)}	_{294,895k (± 0.00%)}	_~	_294,880k	_294,909k	_{p=0.422 n=6}
_{Parse Time}	_{2.39s (± 0.51%)}	_{2.42s (± 0.73%)}	_{+0.03s (+ 1.19%)}	_2.39s	_2.43s	_{p=0.022 n=6}
_{Bind Time}	_{1.06s (± 0.49%)}	_{1.08s (± 1.14%)}	_~	_1.06s	_1.09s	_{p=0.069 n=6}
_{Check Time}	_{7.49s (± 0.26%)}	_{7.54s (± 0.60%)}	_~	_7.47s	_7.59s	_{p=0.091 n=6}
_{Emit Time}	_{4.28s (± 0.48%)}	_{4.30s (± 1.16%)}	_~	_4.24s	_4.39s	_{p=0.373 n=6}
_{Total Time}	_{15.23s (± 0.23%)}	_{15.33s (± 0.61%)}	_{+0.11s (+ 0.69%)}	_15.21s	_15.50s	_{p=0.020 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,968k (± 0.01%)}	_{471,981k (± 0.01%)}	_~	_471,943k	_472,022k	_{p=0.575 n=6}
_{Parse Time}	_{3.37s (± 0.58%)}	_{3.37s (± 0.62%)}	_~	_3.33s	_3.39s	_{p=0.464 n=6}
_{Bind Time}	_{1.01s (± 0.00%)}	_{1.00s (± 0.83%)}	_~	_0.99s	_1.01s	_{p=0.176 n=6}
_{Check Time}	_{18.90s (± 0.32%)}	_{18.91s (± 0.61%)}	_~	_18.77s	_19.05s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.28s (± 0.29%)}	_{23.28s (± 0.54%)}	_~	_23.13s	_23.44s	_{p=1.000 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{539,108k (± 0.00%)}	_{539,153k (± 0.00%)}	_{+45k (+ 0.01%)}	_539,115k	_539,179k	_{p=0.013 n=6}
_{Parse Time}	_{4.21s (± 0.46%)}	_{4.24s (± 0.35%)}	_{+0.03s (+ 0.67%)}	_4.22s	_4.25s	_{p=0.028 n=6}
_{Bind Time}	_{1.66s (± 0.90%)}	_{1.68s (± 0.24%)}	_~	_1.67s	_1.68s	_{p=0.066 n=6}
_{Check Time}	_{3.14s (± 1.04%)}	_{3.16s (± 0.47%)}	_~	_3.14s	_3.18s	_{p=0.126 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.10s (± 0.74%)}	_{9.18s (± 0.13%)}	_~	_9.16s	_9.19s	_{p=0.065 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₇₃₅₆	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..47356

_Metric	_main	₄₇₃₅₆	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,396ms (± 0.75%)}	_{2,416ms (± 0.51%)}	_~	_2,400ms	_2,434ms	_{p=0.078 n=6}
_{Req 2 - geterr}	_{5,412ms (± 0.80%)}	_{5,451ms (± 0.56%)}	_~	_5,415ms	_5,490ms	_{p=0.173 n=6}
_{Req 3 - references}	_{337ms (± 0.56%)}	_{339ms (± 0.36%)}	_~	_337ms	_340ms	_{p=0.251 n=6}
_{Req 4 - navto}	_{280ms (± 0.52%)}	_{282ms (± 0.37%)}	_~	_280ms	_283ms	_{p=0.084 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 3.58%)}	_{77ms (± 7.24%)}	_~	_71ms	_84ms	_{p=0.514 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,519ms (± 0.71%)}	_{2,541ms (± 1.84%)}	_~	_2,464ms	_2,591ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{4,040ms (± 0.46%)}	_{4,051ms (± 0.61%)}	_~	_4,017ms	_4,080ms	_{p=0.471 n=6}
_{Req 3 - references}	_{351ms (± 1.23%)}	_{349ms (± 1.68%)}	_~	_341ms	_358ms	_{p=0.573 n=6}
_{Req 4 - navto}	_{291ms (± 0.79%)}	_{295ms (± 1.44%)}	_~	_291ms	_301ms	_{p=0.126 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 6.15%)}	_{77ms (± 8.45%)}	_~	_69ms	_85ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,032ms (± 0.47%)}	_{3,046ms (± 0.51%)}	_~	_3,018ms	_3,064ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{1,572ms (± 0.94%)}	_{1,585ms (± 1.24%)}	_~	_1,570ms	_1,616ms	_{p=0.376 n=6}
_{Req 3 - references}	_{107ms (± 0.38%)}	_{107ms (± 0.98%)}	_~	_105ms	_108ms	_{p=0.528 n=6}
_{Req 4 - navto}	_{355ms (± 0.63%)}	_{357ms (± 0.75%)}	_~	_353ms	_361ms	_{p=0.677 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{383ms (± 1.20%)}	_{382ms (± 1.63%)}	_~	_372ms	_389ms	_{p=0.872 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,515ms (± 0.71%)}	_{2,516ms (± 0.86%)}	_~	_2,491ms	_2,542ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,791ms (± 0.72%)}	_{5,779ms (± 0.69%)}	_~	_5,727ms	_5,827ms	_{p=0.809 n=6}
_{Req 3 - references}	_{348ms (± 1.04%)}	_{348ms (± 1.13%)}	_~	_342ms	_352ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{280ms (± 1.57%)}	_{278ms (± 0.50%)}	_~	_275ms	_279ms	_{p=0.256 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{74ms (± 0.85%)}	_{74ms (± 1.40%)}	_~	_72ms	_75ms	_{p=0.654 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,686ms (± 0.63%)}	_{2,666ms (± 0.79%)}	_{-21ms (- 0.77%)}	_2,634ms	_2,700ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{4,388ms (± 0.47%)}	_{4,391ms (± 0.51%)}	_~	_4,355ms	_4,424ms	_{p=0.810 n=6}
_{Req 3 - references}	_{357ms (± 0.72%)}	_{357ms (± 0.54%)}	_~	_354ms	_359ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{291ms (± 0.14%)}	_{292ms (± 0.52%)}	_~	_290ms	_294ms	_{p=0.863 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 6.46%)}	_{76ms (± 2.55%)}	_~	_75ms	_80ms	_{p=1.000 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,180ms (± 0.38%)}	_{3,180ms (± 0.41%)}	_~	_3,167ms	_3,201ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,753ms (± 1.86%)}	_{1,752ms (± 1.65%)}	_~	_1,708ms	_1,784ms	_{p=1.000 n=6}
_{Req 3 - references}	_{114ms (± 1.21%)}	_{114ms (± 1.74%)}	_~	_111ms	_117ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{340ms (± 0.64%)}	_{341ms (± 0.91%)}	_~	_339ms	_345ms	_{p=0.560 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{395ms (± 0.94%)}	_{394ms (± 0.44%)}	_~	_393ms	_397ms	_{p=0.870 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,604ms (± 0.44%)}	_{2,618ms (± 0.28%)}	_{+14ms (+ 0.54%)}	_2,609ms	_2,629ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{6,192ms (± 0.64%)}	_{6,193ms (± 0.32%)}	_~	_6,162ms	_6,215ms	_{p=0.810 n=6}
_{Req 3 - references}	_{366ms (± 0.71%)}	_{366ms (± 0.88%)}	_~	_362ms	_371ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{277ms (± 0.46%)}	_{279ms (± 0.48%)}	_~	_278ms	_281ms	_{p=0.054 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{102ms (± 0.50%)}	_{102ms (± 0.88%)}	_~	_101ms	_103ms	_{p=0.541 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,820ms (± 0.46%)}	_{2,825ms (± 0.67%)}	_~	_2,791ms	_2,848ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{4,598ms (± 2.72%)}	_{4,543ms (± 2.14%)}	_~	_4,478ms	_4,738ms	_{p=1.000 n=6}
_{Req 3 - references}	_{395ms (± 8.40%)}	_{418ms (± 5.68%)}	_~	_370ms	_430ms	_{p=0.688 n=6}
_{Req 4 - navto}	_{293ms (± 1.31%)}	_{287ms (± 0.64%)}	_{-6ms (- 1.88%)}	_285ms	_290ms	_{p=0.010 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 8.99%)}	_{88ms (± 6.94%)}	_{+9ms (+11.68%)}	_76ms	_92ms	_{p=0.036 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,444ms (± 0.69%)}	_{3,476ms (± 0.49%)}	_{+31ms (+ 0.91%)}	_3,448ms	_3,493ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{1,870ms (± 0.40%)}	_{1,881ms (± 0.90%)}	_~	_1,851ms	_1,894ms	_{p=0.173 n=6}
_{Req 3 - references}	_{127ms (± 1.16%)}	_{129ms (± 1.96%)}	_~	_126ms	_132ms	_{p=0.256 n=6}
_{Req 4 - navto}	_{370ms (± 0.37%)}	_{373ms (± 0.77%)}	_{+3ms (+ 0.86%)}	_370ms	_378ms	_{p=0.028 n=6}
_{Req 5 - completionInfo count}	_{2,861 (± 0.00%)}	_{2,861 (± 0.00%)}	_~	_2,861	_2,861	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{409ms (± 0.47%)}	_{412ms (± 1.15%)}	_~	_407ms	_420ms	_{p=0.332 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₇₃₅₆	₆
_Baseline	_main	₆

Startup

Comparison Report - main..47356

_Metric	_main	₄₇₃₅₆	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.35ms (± 0.16%)}	_{142.27ms (± 0.20%)}	_{+0.92ms (+ 0.65%)}	_141.21ms	_145.55ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.36ms (± 0.17%)}	_{228.94ms (± 0.41%)}	_{+2.58ms (+ 1.14%)}	_226.72ms	_236.56ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{228.49ms (± 0.21%)}	_{230.02ms (± 0.32%)}	_{+1.54ms (+ 0.67%)}	_228.20ms	_236.66ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{209.45ms (± 0.23%)}	_{212.08ms (± 0.39%)}	_{+2.63ms (+ 1.26%)}	_209.37ms	_217.26ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₇₃₅₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

…eat/7411

Sebastian "Sebbie" Silbermann (eps1lon) · 2023-04-15T09:03:28Z

It's not really clear to me whether this was targetted just at attributes or also element names. The spec does allow namespaced names as far as I can tell so TypeScript should allow it. And considering @types/fbt has been out for a while using namespaced element names, it seems to have worked in the past. But maybe how it worked in the past was not intended?

Either way, can somebody take a look at the test added in https://github.com/microsoft/TypeScript/pull/53784/files since that should resolve the element type to fbt:enum and not treat fbt and enum as different types. Bisected with the test added in #53784 and this PR is the first one to break that test.

…7356)" This reverts commit 0c5be02.

TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Jan 9, 2022

Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as ready for review January 10, 2022 20:04

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch from 9bae221 to da34bcf Compare January 28, 2022 08:50

Nathan Shively-Sanders (sandersn) requested review from Jake Bailey (jakebailey) and Wesley Wigham (weswigham) February 16, 2022 01:05

Nathan Shively-Sanders (sandersn) assigned Wesley Wigham (weswigham) Feb 16, 2022

Wesley Wigham (weswigham) requested changes Mar 5, 2022

View reviewed changes

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch from da34bcf to e70390c Compare March 7, 2022 17:58

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch from e70390c to 5ec03af Compare March 7, 2022 21:34

Oleksandr Tarasiuk (a-tarasyuk) requested a review from Wesley Wigham (weswigham) March 8, 2022 21:02

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch from 5ec03af to 1ee401a Compare March 10, 2022 10:05

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch 2 times, most recently from ac7f3d6 to 2ff0115 Compare March 23, 2022 14:43

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch 2 times, most recently from eac179e to 888f234 Compare April 11, 2022 21:02

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch from 888f234 to 7ec2312 Compare April 26, 2022 19:46

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch from 7ec2312 to c8c81f8 Compare May 17, 2022 19:31

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch from c8c81f8 to 42642c6 Compare June 22, 2022 11:17

feat(7411): add JSXNamespacedName

ff771af

Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/7411 branch from 42642c6 to ff771af Compare July 9, 2022 16:49

Oleksandr Tarasiuk (a-tarasyuk) added 2 commits September 6, 2022 21:15

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

4926694

…eat/7411

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

a4abf96

…eat/7411

escape jsx attribute name

23379dd

Wesley Wigham (weswigham) approved these changes Mar 20, 2023

View reviewed changes

Wesley Wigham (weswigham) assigned Ryan Cavanaugh (RyanCavanaugh) and unassigned Wesley Wigham (weswigham) Mar 20, 2023

Oleksandr Tarasiuk (a-tarasyuk) added 2 commits April 12, 2023 00:11

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

9a7ad07

…eat/7411

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

98c3eb6

…eat/7411

Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 13, 2023

View reviewed changes

Comment thread src/compiler/checker.ts

Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 13, 2023

View reviewed changes

Comment thread src/compiler/diagnosticMessages.json

Oleksandr Tarasiuk (a-tarasyuk) requested a review from Daniel Rosenwasser (DanielRosenwasser) April 14, 2023 01:04

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

3217745

…eat/7411

Daniel Rosenwasser (DanielRosenwasser) approved these changes Apr 14, 2023

View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) merged commit 0c5be02 into microsoft:main Apr 14, 2023

This was referenced Apr 15, 2023

[test] Intrinsics with colon no longer type-checked #53784

Closed

[react] Allow returning ReactNode from function components DefinitelyTyped/DefinitelyTyped#65135

Merged

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Apr 15, 2023

Revert "feat(7411): JSX namespaced attribute syntax not supported" #53791

Closed

Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Apr 15, 2023

Revert "feat(7411): JSX namespaced attribute syntax not supported (#4…

fc1beb0

…7356)" This reverts commit 0c5be02.

Oleksandr Tarasiuk (a-tarasyuk) mentioned this pull request Apr 16, 2023

feat(7411): Resolve intrinsics elements by JSX namespaced tag names #53799

Merged

Wesley Wigham (weswigham) mentioned this pull request May 2, 2023

JSX namespace names should not be considered expressions #54104

Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Oleksandr Tarasiuk (a-tarasyuk) commented Jan 9, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 10, 2022

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

Oleksandr Tarasiuk (a-tarasyuk) commented Mar 7, 2022

Uh oh!

Wesley Wigham (weswigham) commented Mar 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Oleksandr Tarasiuk (a-tarasyuk) commented Mar 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wesley Wigham (weswigham) commented Mar 7, 2022

Uh oh!

Oleksandr Tarasiuk (a-tarasyuk) commented Mar 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wesley Wigham (weswigham) commented Mar 7, 2022

Uh oh!

Oleksandr Tarasiuk (a-tarasyuk) commented Jun 24, 2022

Uh oh!

Wesley Wigham (weswigham) left a comment

Choose a reason for hiding this comment

Uh oh!

Wesley Wigham (weswigham) commented Mar 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 21, 2023

Compiler

TSServer

Startup

Uh oh!

Uh oh!

Uh oh!

Sebastian "Sebbie" Silbermann (eps1lon) commented Apr 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Wesley Wigham (weswigham) commented Mar 7, 2022 •

edited

Loading

Oleksandr Tarasiuk (a-tarasyuk) commented Mar 7, 2022 •

edited

Loading

Oleksandr Tarasiuk (a-tarasyuk) commented Mar 7, 2022 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 20, 2023 •

edited

Loading