fix(15230): "Cannot compile namespaces" error with --isolatedModules and no namespaces - #40032
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit intoAug 13, 2020
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/15230
branch
from
August 13, 2020 09:11
ff7b79b to
2838326
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
August 13, 2020 09:13
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/15230
branch
from
August 13, 2020 18:44
2838326 to
69902bc
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
August 13, 2020 18:46
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Aug 13, 2020
Nathan Shively-Sanders (sandersn)
requested changes
Aug 13, 2020
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
- 'global' is still a slightly jargon-ish term, but I don't know a better one.
- I think we can cut the error down slightly if the error is always in a non-module file.
…an --isolatedModules project
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/15230
branch
from
August 13, 2020 20:34
69902bc to
a49591e
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Nathan Shively-Sanders (sandersn)
August 13, 2020 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15230