Repository navigation
Fixups for libstdc++-10 support - #133
Conversation
|
Discussing with Greg Lapinski (@grlap), this one-line fix isn't going to work due to the fact that Some options to consider to use an explicit lengthed type (e.g. Still unclear what changed however. None of the C++ code referencing this has changed since August. I suspect something in the Github Ubuntu runners config has changed but I haven't seen what yet. Can't reproduce the issue locally either. |
|
Figured it out: Github added actions/runner-images@207f49e#diff-29b87ca86e8166171be2d4cf761d6e8f |
…0 issues GNU libstdc++ 10 uses the token `__in` in some generated code, so we need to avoid it.
|
With the first fix we were getting type of errors. /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/basic_string.tcc:1501:63: error: expected expression
const __ctype_type& __ct = use_facet<__ctype_type>(__in.getloc());This was because we had cases of 6d318b0 fixes that by switching to That still doesn't address the |
|
For the record, the |
Recently we discovered the following error in CI for Linux builds:
Scanning dependencies of target Mlos.Core make[3]: Leaving directory '/home/runner/work/MLOS/MLOS/out/cmake/Debug' make[3]: Entering directory '/home/runner/work/MLOS/MLOS/out/cmake/Debug' [ 20%] Building CXX object source/Mlos.Core/CMakeFiles/Mlos.Core.dir/ArenaAllocator.cpp.o In file included from /home/runner/work/MLOS/MLOS/source/Mlos.Core/ArenaAllocator.cpp:16: In file included from /home/runner/work/MLOS/MLOS/source/Mlos.Core/Mlos.Core.h:90: In file included from /home/runner/work/MLOS/MLOS/source/Mlos.Core/PropertyProxy.h:18: In file included from /home/runner/work/MLOS/MLOS/source/Mlos.Core/ObjectSerialization.h:19: /home/runner/work/MLOS/MLOS/source/Mlos.Core/StringTypes.h:89:38: error: use of undeclared identifier 'wcslen' Length = string != nullptr ? wcslen(string) : 0; ^ /home/runner/work/MLOS/MLOS/source/Mlos.Core/StringTypes.h:105:61: error: use of undeclared identifier 'wcsncmp' return lhs.Length == rhs.Length && (lhs.Length == 0 || (wcsncmp(lhs.Data, rhs.Data, lhs.Length) == 0)); ^ 2 errors generated.Not entirely sure how this snuck in since I can't find anything on the C++ side which has changed recently and tests were passing a few days ago, but here we are.
It seems that we weren't including the wide character string functions in the standard libs previously. This small change should fix that.