Repository navigation
MLOS lab 3 Leveldb tuning - #129
Conversation
|
Thanks for the PR. Can you please sign the CLA? |
|
As I had mentioned, I think for this example we don't need to use the grpc and can run the optimizer directly as in the Bayesian Optimization notebook. |
|
Hello Andreas,
I have signed the CLA. I will work on the changes today.
Thank you,
Nithin
…On Wed, Oct 7, 2020 at 6:59 PM Andreas Mueller ***@***.***> wrote:
As I had mentioned, I think for this example we don't need to use the grpc
and can run the optimizer directly as in the Bayesian Optimization notebook.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#129 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADDJUZEOVJ5OMEUWSSVFS63SJT6H5ANCNFSM4SGYZHRQ>
.
|
|
Hello Andreas,
I have made the requested changes. Please feel free to go through the
notebook and see if it looks good and add additional going
further questions. It will be helpful if you can run the notebook once and
see if there are no issues, I have tested it on my end on Ubuntu 18.04
machine.
Thank you,
Nithin
…On Thu, Oct 8, 2020 at 10:48 AM Nithin V ***@***.***> wrote:
Hello Andreas,
I have signed the CLA. I will work on the changes today.
Thank you,
Nithin
On Wed, Oct 7, 2020 at 6:59 PM Andreas Mueller ***@***.***>
wrote:
> As I had mentioned, I think for this example we don't need to use the
> grpc and can run the optimizer directly as in the Bayesian Optimization
> notebook.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#129 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADDJUZEOVJ5OMEUWSSVFS63SJT6H5ANCNFSM4SGYZHRQ>
> .
>
|
|
Thanks nithinv13 for your contribution! As discussed, we will add another PR for integrating the notebook to the website menu and refine the notebook for additional "going forward" suggestions. |
| " \"experiment_designer_config.fraction_random_suggestions\": 0.5,\n", | ||
| " \"experiment_designer_config_fraction_random_suggestions\": 0.1\n", | ||
| "}.\n", | ||
| "10/08/2020 21:58:26 - BayesianOptimizerFactory - INFO - [BayesianOptimizerFactory.py: 40 - create_local_optimizer() ] Creating a bayesian optimizer with config: {\n", |
There was a problem hiding this comment.
nithinv13 this optimizer creation output seems repeated a number of times. What's up with that?
| " \"experiment_designer_config.fraction_random_suggestions\": 0.5,\n", | ||
| " \"experiment_designer_config_fraction_random_suggestions\": 0.1\n", | ||
| "}.\n", | ||
| "10/08/2020 21:58:27 - BayesianOptimizerFactory - INFO - [BayesianOptimizerFactory.py: 40 - create_local_optimizer() ] Creating a bayesian optimizer with config: {\n", |
There was a problem hiding this comment.
nithinv13 this optimizer creation output seems repeated a number of times. What's up with that?
| "#optimizer = bayesian_optimizer_factory.create_remote_optimizer(optimization_problem=optimization_problem)\n", | ||
| "def run_optimizer():\n", | ||
| " # Parameter 1: write_buffer_size: min_value = 1 MB, max_value = 128 MB\n", | ||
| " # Parameter 2: max_file_size: min_value = 1 MB, max_value = 128 MB\n", |
There was a problem hiding this comment.
nithinv13 as mentioned: although these might be the experimentally chosen values you used, we could consider to expand the range to ensure that a different machine/workload doesn't find something else.
| ], | ||
| "source": [ | ||
| "# Optimization Problem\n", | ||
| "# You might have to change the min and max value based on the objective that you are using \n", |
There was a problem hiding this comment.
nithinv13 this note probably needs more details.
Actually, a better way would be to give the ContinuousDimension parameter some better names than objective so that it's more clear that if they're tuning for "latency" they want ranges from (0, n] some time units based on their hardware vs. if they're tuning for "throughput" they want ranges from (0, m] MB/s based on their hardware.
Either way, I think providing slightly higher bounds than are expected is good so that you don't accidentally end up capping the optimization problem's output if your benchmarks somehow exceed that.
No description provided.