Repository navigation
Docker image publishing work - #128
Merged
Brian Kroth (bpkroth) merged 97 commits intoOct 13, 2020
Merged
Conversation
one that we can nest under the microsoft account on dockerhub
testing first, then we'll make changes to use it during the other CI pipelines
- add better support for forked repos (less secret setup required) - fewer container image version cleanup tasks required Will need to eventually move to Github Container Registry (ghcr.io) once they add support for automatic GITHUB_TOKEN secrets.
- needs to load the image from buildx into local docker for starting - docker requires registry names to be all lowercase
also make some of the job names easier to read if cut off
…t need to also cleanup the apt caches during each stage to reduce layer size
... to stop automatically calling the setup-{cmake,dotnet} scripts and
move us toward just using the system installed versions
... to begin to stop needing commands in tools/bin/ to be setup
Greg Lapinski (grlap)
approved these changes
Oct 5, 2020
This was
linked to
issues
Oct 5, 2020
Andreas Mueller (amueller)
approved these changes
Oct 7, 2020
|
Brian Kroth (@bpkroth), this is an impressive piece of work! Very cool! |
but use the full set during Merge and scheduled runs See Also: https://docs.github.com/en/free-pro-team@latest/actions/reference/context-and-expression-syntax-for-github-actions#example-6
This reverts commit 955de7c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of build/pipeline cleanup with the goal of making and publishing standard Docker images the for Linux developers and the CI pipelines (#36).
.github/workflows/main.yml, but here's a brief summary:Jobs are organized into dependency graphs to account for this cache reuse.
At the moment, all of the tests run on all versions of Ubuntu, which makes the CI pipeline a bit slow.
GITHUB_TOKENsecret so doesn't require any additional work for a forked repo to use for testing (they push to their own path though). However, it doesn't support anonymous pulls and is being deprecated by ...Additional work:
/src/MLOSfolder in the image so that one couldgit pullimmediately to get the latest code if they wanted to without a local copy as a bind mount.make docker-imagetarget to simplify repeated local docker image build invocations.install.python.shscript to setup thepython3.7install. Will port that over later as well.This required a fair bit of fixups, but I think should cut down on some issues with students/others and makes the vscode integration easier as well.