Repository navigation
[SPIR-V][vk::SampledTexture] #12. Support vk::SampledTexture3D type. - #8213
Merged
Merged
Conversation
Lucie Choi (luciechoi)
requested review from
Nathan Gauër (Keenuts) and
Steven Perron (s-perron)
February 27, 2026 22:15
Lucie Choi (luciechoi)
force-pushed
the
texture3d
branch
from
March 4, 2026 19:49
041455d to
a06a5a6
Compare
Lucie Choi (luciechoi)
changed the title
vk::SampledTexture3D type.vk::SampledTexture3D type.
Lucie Choi (luciechoi)
force-pushed
the
texture3d
branch
from
April 13, 2026 20:00
a06a5a6 to
5a5c6f0
Compare
Collaborator
Author
|
(Steven Perron (@s-perron) Nathan Gauër (@Keenuts) this is the next sampled texture PR, I'll add the negative test cases for all the types functions in another CL) |
Steven Perron (s-perron)
approved these changes
Apr 14, 2026
Steven Perron (s-perron)
left a comment
Steven Perron (s-perron)
left a comment
Collaborator
There was a problem hiding this comment.
Minor suggestions. You can merge once you have them fixed.
Lucie Choi (luciechoi)
force-pushed
the
texture3d
branch
from
April 14, 2026 21:43
f600cb3 to
c04b38f
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Lucie Choi (luciechoi)
force-pushed
the
texture3d
branch
from
April 14, 2026 21:45
c04b38f to
bea9ac4
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Lucie Choi (luciechoi)
force-pushed
the
texture3d
branch
from
April 14, 2026 21:47
bea9ac4 to
4625d09
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Lucie Choi (luciechoi)
force-pushed
the
texture3d
branch
from
April 14, 2026 21:49
4625d09 to
72f3df6
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Lucie Choi (luciechoi)
enabled auto-merge (squash)
April 14, 2026 21:51
Nathan Gauër (Keenuts)
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7979
The function definitions are equivalent to that of Texture3D counterparts, just without Sampler argument.