Repository navigation
Remove unnecessary in C++11 c_str() calls - #5932
Merged
Joshua Batista (bob80905) merged 2 commits intoOct 25, 2023
Merged
Conversation
While theoratically required in pre-C++11 to avoid re-allocation upon call, C++11 guarantees that c_str() returns a pointer to the internal array so pre-calling c_str() is no longer required. llvm-svn: 242983
Gregory Roth (pow2clk)
approved these changes
Oct 25, 2023
Gregory Roth (pow2clk)
left a comment
Gregory Roth (pow2clk)
left a comment
Collaborator
There was a problem hiding this comment.
Looks clean!
Chris B (llvm-beanz)
approved these changes
Oct 25, 2023
Damyan Pepper (damyanp)
approved these changes
Oct 25, 2023
Joshua Batista (bob80905)
added a commit
to bob80905/DirectXShaderCompiler
that referenced
this pull request
Oct 25, 2023
While theoratically required in pre-C++11 to avoid re-allocation upon call, C++11 guarantees that c_str() returns a pointer to the internal array so pre-calling c_str() is no longer required. llvm-svn: 242983 --------- Co-authored-by: Yaron Keren <yaron.keren@gmail.com>
Joshua Batista (bob80905)
added a commit
that referenced
this pull request
Oct 25, 2023
Joshua Batista (bob80905)
added a commit
that referenced
this pull request
Oct 26, 2023
While theoratically required in pre-C++11 to avoid re-allocation upon call, C++11 guarantees that c_str() returns a pointer to the internal array so pre-calling c_str() is no longer required. llvm-svn: 242983 --------- --------- Co-authored-by: Yaron Keren <yaron.keren@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While theoratically required in pre-C++11 to avoid re-allocation upon call, C++11 guarantees that c_str() returns a pointer to the internal array so pre-calling c_str() is no longer required.
llvm-svn: 242983