Repository navigation
[lit] convert verify test as lit FileCheck test part1 - #5904
Merged
Merged
Conversation
Convert first part of shaders as lit FileCheck test. This is for microsoft#5870 CppErrorsHV2015 is skipped for cannot set hlsl 2015 thru dxc. CppErrors is skipped for non-expected warning when test with taef.
Joshua Batista (bob80905)
left a comment
Joshua Batista (bob80905)
left a comment
Collaborator
There was a problem hiding this comment.
Can you explain your reasoning for why you chose to make the target profile lib_6_3? As opposed to, say, 6_0 or 6_5?
Contributor
Author
I want to use lib profile because it doesn't require entry. |
Joshua Batista (bob80905)
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert first part of verify test shaders as lit FileCheck test.
This is for #5870
CppErrorsHV2015 is skipped for cannot set hlsl 2015 thru dxc.
CppErrors is skipped for non-expected warning when test with taef.