Repository navigation
[lit][SPIRV] convert runFileTest shaders to lit FileCheck test - #5898
Merged
Merged
Conversation
Xiang Li (python3kgae)
requested review from
Nathan Gauër (Keenuts),
Cassandra Beckley (cassiebeckley) and
Steven Perron (s-perron)
October 19, 2023 15:31
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Moved from bottom, skipped CompatibilityWithVk1p1.
Convert the moved shaders to lit FileCheck test.
Xiang Li (python3kgae)
force-pushed
the
mv_spirv
branch
from
October 19, 2023 17:23
abb1100 to
6f60de9
Compare
Cassandra Beckley (cassiebeckley)
approved these changes
Oct 20, 2023
Steven Perron (s-perron)
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert from bottom of CodeGenSpirvTest.cpp.
Skipped FileTest::CompatibilityWithVk1p1 as barrier for runCodeTest.