Repository navigation
Use botframework-streaming browser dist; misc. refactoring and linting - #305
Closed
Steven Gum (stevengum) wants to merge 6 commits into
Closed
Steven Gum (stevengum) wants to merge 6 commits into
Steven Gum (stevengum) wants to merge 6 commits into
Conversation
Steven Gum (stevengum)
marked this pull request as ready for review
September 1, 2020 22:37
Steven Gum (stevengum)
changed the title
Member
Author
|
Closing in favor of #306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specific Changes
directLine.tstotypes.tsimport * as BFSE from 'botframework-streaming'toimport { ... } from 'botframework-streaming/browser/index-browser'CHANGELOG.mdwith corresponding changesTesting
The change in
directLineStreaming.tsto point to'botframework-streaming/browser/index-browser'has been validated with unit tests and tested E2E withbotframework-webchat@4.10.0via the following matrix:botframework-streaming@4.9.2botframework-streamingvia microsoft/botbuilder-js#2753This also serves as the starting point for addressing issue #288.