Skip to content

Directline sdk is broken without installing certain packages. Please address #288

New issue
New issue
Closed
Closed
Directline sdk is broken without installing certain packages. Please address#288
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.R11Release 11 - November 15th, 2020customer-replied-toRequired for internal reporting. Do not delete.customer-reportedRequired for internal Azure reporting. Do not delete.

Description

@xtianus79
xtianus79
opened on Jun 21, 2020

Here is the errors from rxjs not working

ERROR in ./node_modules/botframework-directlinejs/lib/directLineStreaming.js
Module not found: Error: Can't resolve 'rxjs/BehaviorSubject' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/BehaviorSubject' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLineStreaming.js
Module not found: Error: Can't resolve 'rxjs/Observable' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/Observable' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/observable/dom/ajax' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/observable/empty' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/observable/from' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/observable/interval' in '/mnt/c/repos/ai-xxxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/observable/of' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/observable/throw' in '/mnt/c/repos/ai-xxxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/catch' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/combineLatest' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/concatMap' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/count' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/delay' in '/mnt/c/repos/ai-xxxxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/do' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/filter' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/map' in '/mnt/c/repos/ai-xxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/mergeMap' in '/mnt/c/repos/ai-xxxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/retryWhen' in '/mnt/c/repos/ai-xxxxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/share' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/add/operator/take' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

ERROR in ./node_modules/botframework-directlinejs/lib/directLine.js
Module not found: Error: Can't resolve 'rxjs/scheduler/async' in '/mnt/c/repos/ai-xxxxxxxx-frontend-website/node_modules/botframework-directlinejs/lib'

After installing rxjs-compat or I'm assuming rxjs 5.0
these are the remaining errors

ERROR in ./node_modules/botframework-streaming/browser/webSocket/nodeWebSocket.js
Module not found: Error: Can't resolve 'crypto' in '/mnt/c/repos/ai-xxxxxx-frontend-website/node_modules/botframework-streaming/browser/webSocket'
ERROR in ./node_modules/botframework-streaming/browser/webSocket/nodeWebSocket.js
Module not found: Error: Can't resolve 'http' in '/mnt/c/repos/ai-xxxxxxxxx-frontend-website/node_modules/botframework-streaming/browser/webSocket'
ERROR in ./node_modules/botframework-streaming/browser/subscribableStream.js
Module not found: Error: Can't resolve 'stream' in '/mnt/c/repos/ai-xxxxxxxx-frontend-website/node_modules/botframework-streaming/browser'

Activity

  1. Kyle Delaney (v-kydela)
    added
    Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.
    customer-reportedRequired for internal Azure reporting. Do not delete.
    on Jun 22, 2020
  2. Chris Whitten (cwhitten)
    assigned
    William Wong (compulim)
    on Jun 22, 2020

  3. compulim commented on Jun 22, 2020

    @compulim
    William Wong (compulim)
    on Jun 22, 2020
    Collaborator

    xtianus79 what bundler are you using? I am guessing it is not Webpack, so it don't turn crypto/http/stream into node-libs-browser.

    Steven Gum (@stevengum) I think we need to take away Node.js dependencies from botframework-streaming.

  4. Srinaath Ravichandran (srinaath)
    added
    customer-replied-toRequired for internal reporting. Do not delete.
    on Jun 23, 2020

  5. xtianus79 commented on Jun 24, 2020

    @xtianus79
    xtianus79
    on Jun 24, 2020
    Author

    William Wong (@compulim) I am using Angular cli 9+ and to make matters super interesting Angular universal. lol I always have to decide if that is a culprit.

  6. compulim commented on Jun 26, 2020

    @compulim
    William Wong (compulim)
    on Jun 26, 2020
    Collaborator

    xtianus79 I think there are two issues:

    We assume Webpack is everything. But in fact, Webpack is too magical (automatically convert Node.js package into node-libs-browser). Steven Gum (@stevengum) and Ashley Finafrock (@Zerryth) are trying to take away Node.js package or directly linking to node-libs-browser

    Another issue is the version of RxJS we are using is too old (5.5.10). May be it conflict with the version Angular brought in.

    We are not very familiar with Angular. Could you provide a minimal repos that can build and host Web Chat on Angular? So we could check that into our repos and make sure we our integration test will test basic functionality on Web Chat on Angular?

  7. Steven Gum (stevengum)
    self-assigned this
    on Jun 26, 2020

  8. stevengum commented on Jun 26, 2020

    @stevengum
    Steven Gum (stevengum)
    on Jun 26, 2020
    Member

    Closed #289 as the same error message was being reported here. Additionally, I have the same concerns about the missing node-libs-browser.

    Steven Gum (@stevengum) I am using in the project 3.8.3 but the streaming 3.5.2 is causing the issue I believe.

    xtianus79 regarding version of TypeScript used (comment)

  9. stevengum commented on Jul 8, 2020

    @stevengum
    Steven Gum (stevengum)
    on Jul 8, 2020
    Member

    Quick update from my end for botframework-streaming:

    I’m currently working on removing the node.js specific dependencies and either replacing it with an explicit pollyfill or creating a Node/Browser specific implementation classes.

    I have a simple manual integration test that I’m using to validate the work I’m doing.

    This work will ship with R10.

  10. Emilio Munoz (munozemilio)
    added
    R10Release 10 - August 17th, 2020
    on Jul 20, 2020
  11. William Wong (compulim)
    removed their assignment
    on Aug 5, 2020
  12. Steven Gum (stevengum)
    added
    R11Release 11 - November 15th, 2020
    and removed
    R10Release 10 - August 17th, 2020
    on Aug 7, 2020

  13. stevengum commented on Aug 7, 2020

    @stevengum
    Steven Gum (stevengum)
    on Aug 7, 2020
    Member

    Unfortunately there isn't enough R10 bake time for the removal of the Node.js dependencies in the botframework-streaming.

    The currently targeted milestone is R11.

  14. Peter Innes (peterinnesmsft)
    added
    ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.
    on Aug 19, 2020

  15. stevengum commented on Feb 10, 2021

    @stevengum
    Steven Gum (stevengum)
    on Feb 10, 2021
    Member

    The crypto, http, and stream dependency resolution issue has been fixed via #323.

  16. Steven Gum (stevengum)
    removed their assignment
    on Feb 10, 2021

  17. stevengum commented on Feb 10, 2021

    @stevengum
    Steven Gum (stevengum)
    on Feb 10, 2021
    Member

    The fix for resolving Node.js dependencies was just released in version 0.14.1 of botframework-directlinejs.

  18. corinagum commented on Feb 11, 2021

    @corinagum
    Corina (corinagum)
    on Feb 11, 2021
    Contributor

    Closing as resolved.

  19. Corina (corinagum)
    closed this as completedon Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.R11Release 11 - November 15th, 2020customer-replied-toRequired for internal reporting. Do not delete.customer-reportedRequired for internal Azure reporting. Do not delete.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions