Conversation
Contributor
Author
|
Sorry, this PR was opened accidentally. Astra made this decision automatically while I was using the loop workflow to work on my own project. This PR has not been reviewed, so I am closing it. I will submit a new PR later with a complete root-cause analysis and after review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A foreground notification can consume mouse release while the window selection layer retains an active gesture. Moving the pointer afterward can unexpectedly extend text selection underneath it. Prevent gestures from starting through an occluding surface, and end an active gesture on captured left release, button-up movement, or window deactivation.
The change stays in the window selection owner. Proxy endpoints remain usable to extend a legitimate drag but cannot start one outside a hit participant. Activation observation is retained once per window selection state.
Validation:
cargo test -p gpui-base --lib text_selection:: --locked: 46 passed.AI assistance: implementation and tests were AI-generated and refined against failing dispatched-event regressions, with independent agent review. Human review/testing required by CONTRIBUTING remains pending; this PR is a draft.
Downstream issue: Tryanks/tcode#360