Reset a project thread expansion when its folder collapses - #382
Merged
Merged
Conversation
Tryanks
marked this pull request as ready for review
September 8, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapsing a project resets only that project’s expanded thread list. Reopening in wide layout shows the normal six-thread limit and Show more. This also applies when the folder was collapsed in compact layout. Other projects’ expansions and parent/child folds are preserved, and direct Show less continues to work.
Closes #354.
The change stays in SessionsSidebar’s project-header transition, shared by wide and compact layouts. DESIGN documents the interaction and the existing compact full-list behavior. Existing English and Chinese labels are reused.
Evidence:
0391c0b37598258a82ec29d5d09b1503cf8b8d8c: expand alpha and beta, collapse alpha, reopen alpha. In both light/dark themes, alpha shows threads 0–5 + Show more while beta retains threads 0–6 + Show less; both child folds remain closed. Retained, inspected PNGs:/tmp/tcode-354-evidence/light-reopened.pngand/tmp/tcode-354-evidence/dark-reopened.png(1152×768). Compact-collapse→wide behavior is covered by the actual sidebar regression and prior native verification.0391c0b37598258a82ec29d5d09b1503cf8b8d8cpassed:cargo fmt --all --check,cargo clippy --workspace --all-targets --locked -- -D warnings,cargo build --workspace --locked, andcargo test --workspace --locked(1,084 passed, 0 failed, 5 explicitly ignored across reported suites).cargo-machete .version 0.9.2; this environment’scargo macheteforwards the subcommand as a directory, so the same installed executable was invoked directly.RUSTFLAGS='-D warnings', using the workflow’s targets and Android NDK 27.1.12297006. Native debug linking reports an existing large__eh_framewarning; Cargo reports the existingblockfuture-incompatibility notice./tmp/tcode-354-evidence/build.json. The isolated app was launched with verified throwaway data/worktree environment and stopped after capture. All required GitHub CI checks passed on this exact head: run 34221950756. The standardgh run watch --exit-statuscompleted with exit 0.Final code, local results and retained screenshots were independently reviewed. Integration with main after #380 was checked with a clean merge tree; the sidebar implementation is unchanged from the tested head.