Skip to content

Migrate 'Failed to delete account' alert from Vuetify to Kolibri Des… #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MisRob merged 1 commit into from
Jun 4, 2025
Merged

Migrate 'Failed to delete account' alert from Vuetify to Kolibri Des… #5079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions contentcuration/contentcuration/frontend/settings/pages/Account/DeleteAccountForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,15 @@
@input="deletionEmailInvalidMessage = ''"
/>
</KModal>
<Alert
v-model="deletionFailed"
:header="$tr('deletionFailed')"
:text="$tr('deletionFailedText')"
/>

<KModal
v-if="deletionFailed"
:title="$tr('deletionFailed')"
:submitText="$tr('ok')"
@submit="deletionFailed = false"
>
<p>{{ $tr('deletionFailedText') }}</p>
</KModal>
</div>

</template>
Expand All @@ -33,13 +37,9 @@
<script>

import { mapActions, mapState } from 'vuex';
import Alert from 'shared/views/Alert';

export default {
name: 'DeleteAccountForm',
components: {
Alert,
},
props: {
value: {
type: Boolean,
Expand Down Expand Up @@ -98,6 +98,7 @@
deletionFailed: 'Failed to delete account',
deletionFailedText:
'Failed to delete your account. Please contact us here: https://community.learningequality.org.',
ok: 'OK',
},
};

Expand Down
17 changes: 13 additions & 4 deletions contentcuration/contentcuration/frontend/settings/pages/__tests__/deleteAccountForm.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,20 @@ describe('deleteAccountForm', () => {
wrapper.vm.deleteUserAccount();
expect(deleteAccount).toHaveBeenCalled();
});
it('should show alert if account deletion fails', async () => {
it('should show KModal if account deletion fails', async () => {
await wrapper.setData({ accountDeletionEmail: email });
deleteAccount.mockImplementation(() => Promise.reject('error'));
wrapper.vm.deleteUserAccount().catch(() => {
expect(wrapper.vm.deletionFailed).toBe(true);
});
try {
await wrapper.vm.deleteUserAccount();
} catch (e) {
throw new Error(e);
}
await wrapper.vm.$nextTick();
const modals = wrapper.findAllComponents({ name: 'KModal' });
const errorModal = modals.at(1);
expect(errorModal.exists()).toBe(true);
expect(errorModal.text()).toContain(
'Failed to delete your account. Please contact us here: https://community.learningequality.org.',
);
});
});