Migrate 'Failed to delete account' alert from Vuetify to Kolibri Des…

[Abhishek-Punhani]

Summary

• Replaced Vuetify Alert with K-Modal
• No UI changed
  …

References

#5062
…

Reviewer guidance

• Login as user@a.com
• Go to Settings > Account
• In code, temporarily modify deletionFailed to display the alert

…

[MisRob]

Hi @Abhishek-Punhani, thanks, implementation is as expected and manual testing passes!

One possible area to address on this opportunity would be to update should show alert if account deletion fails test case. Instead of expect(wrapper.vm.deletionFailed).toBe(true);, we rather want to check that KModal component is displayed with the correct text. You don't need to test everything about how that modal looks like since that's covered by KDS, just a basic check that it shows.

This will also cleanup a bit of our old tech debt - previous use of deletionFailed value to test whether the alert is really displayed or not is fragile approach.

It's not blocking. Let me know if that's something you'd like to addres.

[Abhishek-Punhani]

Sure I will update the unit tests as well

[Abhishek-Punhani]

Hi @Abhishek-Punhani, thanks, implementation is as expected and manual testing passes!

One possible area to address on this opportunity would be to update should show alert if account deletion fails test case. Instead of expect(wrapper.vm.deletionFailed).toBe(true);, we rather want to check that KModal component is displayed with the correct text. You don't need to test everything about how that modal looks like since that's covered by KDS, just a basic check that it shows.

This will also cleanup a bit of our old tech debt - previous use of deletionFailed value to test whether the alert is really displayed or not is fragile approach.

It's not blocking. Let me know if that's something you'd like to addres.

@MisRob I have updated the PR , please check at your convenience

[MisRob]

Thanks @Abhishek-Punhani!