fix: opacify functions using {Expr,Level}.data - #8821
Open
digama0 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #8554, and the fixes #8559, #8560 for it. These fixed the main issue, but currently it is still possible to prove that the functions cannot be correct because they involve projecting out of a finite type. This fixes the issue without any performance impact by changing all the
defs that useExpr.Datatoopaque(as suggested here), so we can soundly assume as an axiom that the functions are implemented correctly. This will unblock lean4lean.