fix: block potential adversarial exploit of non-aborting assert! - #8560
Merged
Conversation
This PR is similar to #8559, but for `Expr.mkData`
leodemoura
enabled auto-merge
May 31, 2025 02:53
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
kim-em
added a commit
to kim-em/lean4lean
that referenced
this pull request
Aug 2, 2026
leanprover/lean4#8554 is a closed PR, not an issue, and it proposed saturating; the merged fixes are leanprover/lean4#8559 for `Level` and leanprover/lean4#8560 for `Expr`, both of which abort. Rest the choice of total extension on the abort semantics alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5K6isCtnCB86J8fRbVTKS
kim-em
added a commit
to kim-em/lean4lean
that referenced
this pull request
Aug 3, 2026
leanprover/lean4#8554 is a closed PR, not an issue, and it proposed saturating; the merged fixes are leanprover/lean4#8559 for `Level` and leanprover/lean4#8560 for `Expr`, both of which abort. Rest the choice of total extension on the abort semantics alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5K6isCtnCB86J8fRbVTKS
kim-em
added a commit
to kim-em/lean4lean
that referenced
this pull request
Aug 4, 2026
leanprover/lean4#8554 is a closed PR, not an issue, and it proposed saturating; the merged fixes are leanprover/lean4#8559 for `Level` and leanprover/lean4#8560 for `Expr`, both of which abort. Rest the choice of total extension on the abort semantics alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5K6isCtnCB86J8fRbVTKS
kim-em
added a commit
to kim-em/lean4lean
that referenced
this pull request
Aug 6, 2026
leanprover/lean4#8554 is a closed PR, not an issue, and it proposed saturating; the merged fixes are leanprover/lean4#8559 for `Level` and leanprover/lean4#8560 for `Expr`, both of which abort. Rest the choice of total extension on the abort semantics alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5K6isCtnCB86J8fRbVTKS
kim-em
added a commit
to kim-em/lean4lean
that referenced
this pull request
Aug 12, 2026
leanprover/lean4#8554 is a closed PR, not an issue, and it proposed saturating; the merged fixes are leanprover/lean4#8559 for `Level` and leanprover/lean4#8560 for `Expr`, both of which abort. Rest the choice of total extension on the abort semantics alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5K6isCtnCB86J8fRbVTKS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #8559 but for
Expr.mkData. This vulnerability has not been exploited yet, but adversarial users may find a way.