Repository navigation
feat(shared): resolveAll + shared gitHasContent for per-kind source of truth - #20
Merged
Merged
Conversation
…ce of truth Adds SourceOfTruthOverrides.resolveAll(...) returning a Resolved record (flows, namespaceFiles, anyGit, anyKestra, mixed) so TenantSync/NamespaceSync stop duplicating the resolution+gating derivation, and hoists the per-kind gitHasContent(namespaceRoot, flowsSource, filesSource) probe into AbstractGitTask so both tasks share the same Git-only-namespace narrowing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🧪 Java Unit Tests
🔁 Unreleased Commits2 commits since
|
Merged
3 tasks done
Tests report quick summary:success ✅ > tests: 74, success: 74, skipped: 0, failed: 0 unfold for details
|
Malaydewangan09
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the shared plumbing for per-kind source-of-truth (part-of #237), on top of the already-merged #19 (
SourceOfTruthenum +SourceOfTruthOverrides+resolve):SourceOfTruthOverrides.resolveAll(RunContext, flowsOverride, namespaceFilesOverride, fallback)→ aResolvedrecord (flows,namespaceFiles,anyGit,anyKestra,mixed), soTenantSync/NamespaceSyncstop duplicating the resolution + gating derivation.gitHasContent(namespaceRoot, flowsSource, filesSource)probe intoAbstractGitTask(protected static) so both sync tasks share the same Git-only-namespace narrowing instead of each carrying a copy.Why a second PR
#19 was squash-merged with only the first commit while the follow-up refactor commit was still on the branch; this PR lands that refactor cleanly on top of current
main.Consumers
kestra-io/plugin-gitPR #357 calls bothresolveAlland the sharedgitHasContent. That PR pinsplugin-git-lib:1.2.0-SNAPSHOT(mavenLocal) pending the1.2.0release that will include both #19 and this PR.part-of: kestra-io/plugin-git#237
🤖 Generated with Claude Code