Skip to content

test: cover MockKestraApiServer namespace endpoint - #18

Merged
jymaire merged 9 commits into
kestra-io:mainfrom
plisha39-dotcom:test/5-mock-api-server
Sep 21, 2026
Merged

jymaire merged 9 commits into
kestra-io:mainfrom
plisha39-dotcom:test/5-mock-api-server

Conversation

@plisha39-dotcom

@plisha39-dotcom plisha39-dotcom commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

What changes are being made and why?

Related to #5.

MockKestraApiServer lacks direct test coverage in this repository. This draft starts adding that coverage with a test for GET /api/v1/{tenantId}/namespaces/{id}.

The test starts the server, sends an HTTP request, and checks the status, Content-Type, and returned namespace ID. The HTTP client and server are closed after each test.

Remaining work:

  • Validation endpoint
  • Flow retrieval, including forced statuses
  • Flow import and deletion
  • ZIP export and filtering

How the changes have been QAed?

Ran ./gradlew test locally with Java 25: 63 tests passed, 0 failures, 0 skipped.

Contributor Checklist ✅

@github-project-automation github-project-automation Bot moved this to To review in Pull Requests Sep 18, 2026
@MilosPaunovic MilosPaunovic added kind/external Pull requests raised by community contributors area/plugin Plugin-related issue or feature request labels Sep 21, 2026
@MilosPaunovic
MilosPaunovic requested review from a team and fdelbrayelle September 21, 2026 06:07
@fdelbrayelle
fdelbrayelle marked this pull request as ready for review September 21, 2026 06:30
@fdelbrayelle
fdelbrayelle requested review from jymaire and removed request for fdelbrayelle September 21, 2026 06:30

@jymaire jymaire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, two small changes before PR approval

Comment thread src/test/java/io/kestra/plugin/git/shared/testkit/MockKestraApiServerTest.java Outdated
Comment thread src/test/java/io/kestra/plugin/git/shared/testkit/MockKestraApiServerTest.java Outdated

@jymaire jymaire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling feedback so quickly 🚀

@jymaire jymaire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling feedback so quickly 🚀

@jymaire
jymaire merged commit dd6ae90 into kestra-io:main Sep 21, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from To review to Done in Pull Requests Sep 21, 2026
@Malaydewangan09

Copy link
Copy Markdown
Member

@plisha39-dotcom, Just a small note for the future, if you could use GitHub Keywords when opening PRs to connect it to the proper issue (to automate the entire process a bit more), it would be super helpful to us. You can read a bit more about it here (I've added closing keyword for this particular issue)

@plisha39-dotcom

Copy link
Copy Markdown
Contributor Author

Thanks for the review and guidance! This was my first open-source contribution, and I learned a lot along the way. I'll make sure to use closing keywords in future PRs that resolve an issue. Happy to have contributed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugin Plugin-related issue or feature request kind/external Pull requests raised by community contributors

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants