Restore BNB testnet agents and submission readiness - #6
Merged
Merged
Conversation
jh1nresh
marked this pull request as ready for review
September 8, 2026 11:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product outcome
Restore the four curated BSC Testnet Agent Studio integrations and prepare truthful main-track submission documentation. The old indexer dependency and noncanonical card URLs marked all agents unavailable; the old quote schema required a field absent from every real seller quote.
Demand proof/pricing hypothesis: N/A for this repair; existing third-party testnet fees and product scope are unchanged. Distribution target: existing AgentShack marketplace, pending release verification.
State and trust boundaries
No database migration, contract edits, key access, signer/role changes, settlement, cron/config changes, mainnet actions, token movement or external form submission. All transaction code remains chain 97 only. Unrelated AGENTS.md changes and instruction PR #5 are excluded. No UI layout/style change.
Verification
d3a9a2c42675029c93a088f816724909c57c7606against base468e7986270fff192c530117656e532f6fbff62a. The main-only release-readiness job was correctly skipped on that PR run. PR Restore BNB testnet agents and submission readiness #6 subsequently merged as12be25d7abfb7a068b3232be1c3e8e9342037e1fwith a tree identical to the reviewed head; main CI is the merge verification record.Focused security receipt
Accepted defects: noncanonical endpoint/indexer availability mismatch; real signed quotes rejected by the old wallet-field schema; new runtime dependency audit regression.
The fix keeps server-owned endpoints, rejects redirects, limits card/seller streams to 100 KB, rejects unsupported metadata URIs, and fails closed on identity/RPC errors. Quote fixtures test valid signatures, changed targets/terms, wrong signer, invalid hashes, zero/oversized/over-cap fees and funding retry selection. A valid quote is not proof of job execution.
Dependency review: upstream 4.1.3...4.3.0 diff shows the stream parser replacement and browser-client callback-return refactors. The SDK imports jayson/lib/client/browser, not the TCP/TLS streaming parser. The scoped pin stays inside the SDK's declared range and is covered through Connection.getBalance using the real RPC client. The older TCP/TLS parser is not newly exposed by this application.
GHSA-528h-pc64-c93x affects stream-json path filters; a reachable application exploit was not reproduced. The dependency was removed instead of waived. Existing reviewed-baseline dependency risks remain.
Independent read-only code review PASS was completed in user-authorized task
01a080b6-e041-7bb1-81bd-6e9d45f97b2cagainst headd3a9a2c42675029c93a088f816724909c57c7606and base468e7986270fff192c530117656e532f6fbff62a. The separate checker read all 11 changed files and consumers, verified actual CI logs, ran 49 focused tests and 17 independent API handler probes, and read back all four live chain-97 identities/cards. No new blocking finding. Final live SHA recheck: 2026-09-08 11:15:16 UTC. This was not maker self-approval or a GitHub reviewer approval.Retained pre-existing limitations: activation API validates the curated wallet without a fresh per-call registry read; retry protection is limited to already-confirmed funding within the same page session; runtime audit retains 31 affected packages / 2 high. No funded-hire, delivery, deployment or submission PASS is implied.
Delivery / human boundaries
Exact-head CI and independent code review passed, and the user authorized merge and branch cleanup. Submission and deployment readiness remain separate. Preserve existing Vercel aliases and require commit/chain-aware readback before claiming deployment. Do not change the old linked repository, production secrets or existing cron settings as part of this patch.
Production delivery readback still reports
a50d2b11b308bf902f96435dde77b245d0046acc; no deployment PASS receipt was generated. The local readiness JSON records the passing CI checks only, not independent review or a release.Remaining user/organizer inputs: buyer public address and wallet signatures for all four funded hires, registration confirmation or required personal fields/terms, and confirmation that a testnet-only entry meets main-track eligibility. No new jobs, delivery receipts or registration confirmation were fabricated.