Skip to content

Fix codecov - #211

Merged
jfhbrook merged 2 commits into
jfhbrook:masterfrom
dotnetCarpenter:fix_codecov
Dec 16, 2017
Merged

jfhbrook merged 2 commits into
jfhbrook:masterfrom
dotnetCarpenter:fix_codecov

Conversation

@dotnetCarpenter

@dotnetCarpenter dotnetCarpenter commented Dec 16, 2017 •

Copy link
Copy Markdown
Collaborator

This remove the node version of codecov and uses the bash version instead.

So the longer any nonsense codecov when doing local npm test also I put in an auto job flag for tap, so if you got multiple processors, it should speed up tests.

Hurry up and merge this in :) Then I can rebase #209 to master and we see if PR's adds or lower the coverage. But we need at least one coverage report in master before it works.

oh, and I also changed from lcov to clover reports - not sure what the difference is but I found an example with clover and codecov...

@codecov-io

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@080e936). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #211   +/-   ##
=========================================
  Coverage          ?   75.59%           
=========================================
  Files             ?        9           
  Lines             ?      508           
  Branches          ?      115           
=========================================
  Hits              ?      384           
  Misses            ?       45           
  Partials          ?       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080e936...d63541c. Read the comment docs.

@jfhbrook
jfhbrook merged commit 2d22a87 into jfhbrook:master Dec 16, 2017
@jfhbrook

Copy link
Copy Markdown
Owner

Works for me!

I added you as a collaborator, so you should be able to make changes if I die in a ditch. :) I'll try to be around for review and advice though.

@dotnetCarpenter
dotnetCarpenter deleted the fix_codecov branch December 16, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants