[WIP] Logging

[dotnetCarpenter]

This is my initial idea on how to provide logging for ecstatic.

The PR is only half done but the tests and main output is done.

TODO:

• Tests
• Documentation
• Refactor middleware to be able to log all status codes and response length
• Finish getNscaDateTime to handle all time zones

I think this is a candidate for a minor release.

Unfortunately, I don't have time to finish this, this year. If you @jfhbrook or someone else have time, I would love to review.

I noticed that the log code path is run two times for each request, which means that the middleware is run two times for each request but I don't understand why we would do that. The second time the req.method is undefined and req.url is encoded.

[dotnetCarpenter]

hehe failing in node 4 and 5 after I followed airBnB's eslint - dropping node 4 and 5 support to destructuring assignment or make two small fixes in tests... yaa, remove destructuring - it also sounds so negative.

[jfhbrook]

what is this :o

[dotnetCarpenter]

http://www.node-tap.org/snapshots/

[dotnetCarpenter]

I added a comment in the test about how to generate the file

[dotnetCarpenter]

Ref: #208

[dotnetCarpenter]

@jfhbrook What do you think about the idea and about refactoring middleware - would you be up for doing it? Also do you know why the middleware is run twice for each request?

[dotnetCarpenter]

Looks like codecov is broken somehow.. I'll take a quick look

[codecov-io]

Codecov Report

Merging #209 into master will decrease coverage by 0.07%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   75.86%   75.79%   -0.08%     
==========================================
  Files           9        9              
  Lines         518      533      +15     
  Branches      117      122       +5     
==========================================
+ Hits          393      404      +11     
  Misses         45       45              
- Partials       80       84       +4

Impacted Files	Coverage Δ
lib/ecstatic/opts.js	77.39% <66.66%> (-0.87%)	⬇️
lib/ecstatic.js	74.58% <84.21%> (+0.82%)	⬆️
lib/ecstatic/show-dir/index.js	73.68% <0%> (-1.32%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523f273...bb888b4. Read the comment docs.

[dotnetCarpenter]

I'm using this branch of ecstatic, to serve svg and image files to another node program and I never see double logging (re-run of middleware for each request), which leads me to believe that this only happens when requesting via a browser. I was using Chrome..
I'm guessing it could be OPTION or prefetch request that we are not handling very well. It's not completely b0rken but pretty bad for logging and probably has other side-effects.

[jfhbrook]

I know there's code branches that call the original middleware recursively, those would probably be candidates for ways to cause double-logging.

I'm down to do some middleware refactors in general, given I have the time and the understanding necessary to make useful ones. This might also touch on #193 #154 #88

[dotnetCarpenter]

R. I. P.
#259