Skip to content

fix(phone): report app discovery and initialization failures - #346

Merged
ifBars merged 1 commit into
betafrom
fix/beta-phone-app-diagnostics
Oct 4, 2026
Merged

ifBars merged 1 commit into
betafrom
fix/beta-phone-app-diagnostics

Conversation

@ifBars

@ifBars ifBars commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Custom phone app discovery currently reports candidates only with verbose logging, silently skips types without a public parameterless constructor, and reduces initialization failures to the outer exception message. A mod app can therefore be absent with no useful default log, or report only the generic reflection invocation failure.

Log the discovered type count and each initialization attempt at normal verbosity, warn when a constructor is missing, and retain the full exception including the constructor's underlying cause. Registration order, constructor eligibility, exception isolation, and UI behavior are unchanged.

Validation

  • Separate restore/build/test graphs with deployment disabled: MonoMelon 770/770, Il2CppMelon 744/744, zero build warnings/errors. git diff --check passed.
  • IL2CPP game 0.4.7f9, isolated install, disposable copy of a completed save, verbose logging disabled. A local probe supplied one valid app, one app without a default constructor, and one throwing constructor alongside the user's unchanged Mods App DLL.
  • Observed Discovered 4 custom phone app type(s), initialization messages, an explicit missing-constructor warning, and the underlying InvalidOperationException: Phone diagnostic constructor failure. The failure did not stop Mods App initialization. Its home-screen icon was rendered and visually inspected; its open/closed state was checked separately.
  • Mono live game 0.4.7f7 Alternate: separately verified the missing-constructor warning, full underlying constructor exception, and continued initialization of the valid app with verbose logging disabled. Mods App itself was tested only on IL2CPP.
  • Local-only smoke sources, native assemblies, saved games, and captures are excluded from the PR. All test processes stopped; disposable installs, probe projects, saves, and local captures were removed after inspection. The original game API DLL hash still matched the baseline; original installs and save fixtures were unchanged.

Compatibility

No public/protected API, persistent IDs, save formats, or network payloads change. Source and binary signatures, constructor selection, registration order, and continue-after-failure behavior are preserved. The intentional observable change is more actionable normal-verbosity logging.

The user's actual missing Mods App on released beta.7 was reproduced independently. Current beta already restores it through merged #333; this PR makes the discovery/initialization phases visible and does not duplicate that fix. Pallet icon compatibility is addressed separately in #345.

Mods App restored on Schedule I beta 0.4.7f9 with current unreleased S1API fixes

Mods App renders its full interface and opens and closes on beta 0.4.7f9

@ifBars ifBars added bug Something isn't working beta A game update on the beta & alternate-beta steam branches labels Oct 4, 2026
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 25669f58-e5db-4e98-8edc-a67339c15637

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ifBars
ifBars merged commit 219243e into beta Oct 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta A game update on the beta & alternate-beta steam branches bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant