fix(phone): report app discovery and initialization failures - #346
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom phone app discovery currently reports candidates only with verbose logging, silently skips types without a public parameterless constructor, and reduces initialization failures to the outer exception message. A mod app can therefore be absent with no useful default log, or report only the generic reflection invocation failure.
Log the discovered type count and each initialization attempt at normal verbosity, warn when a constructor is missing, and retain the full exception including the constructor's underlying cause. Registration order, constructor eligibility, exception isolation, and UI behavior are unchanged.
Validation
git diff --checkpassed.Discovered 4 custom phone app type(s), initialization messages, an explicit missing-constructor warning, and the underlyingInvalidOperationException: Phone diagnostic constructor failure. The failure did not stop Mods App initialization. Its home-screen icon was rendered and visually inspected; its open/closed state was checked separately.Compatibility
No public/protected API, persistent IDs, save formats, or network payloads change. Source and binary signatures, constructor selection, registration order, and continue-after-failure behavior are preserved. The intentional observable change is more actionable normal-verbosity logging.
The user's actual missing Mods App on released beta.7 was reproduced independently. Current beta already restores it through merged #333; this PR makes the discovery/initialization phases visible and does not duplicate that fix. Pallet icon compatibility is addressed separately in #345.