Skip to content

fix(rendering): restore beta item icons and requested capture size - #345

Merged
ifBars merged 1 commit into
betafrom
fix/beta-f9-phone-icons
Oct 4, 2026
Merged

ifBars merged 1 commit into
betafrom
fix/beta-f9-phone-icons

Conversation

@ifBars

@ifBars ifBars commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Schedule I beta 0.4.7f9 renamed the preview layer to RuntimePreviewGeneration. IconFactory still looked up IconGeneration, which returns -1, leaving custom models outside the native preview camera's layer. Forklift & Pallets 1.2.0 consequently exhausted its retries with transparent pallet icons.

Resolve the current layer with a legacy-name fallback, report a missing preview layer explicitly, and pass the caller's size into the beta native GetTexture overload. Previously that argument was ignored and native captures always used 512.

Validation

  • Exact base: beta at c3ec3a22f7a0d85439287acb6d36b5b30f66f84d.
  • Separate restore/build/test graphs with automatic deployment disabled: MonoMelon 775/775, Il2CppMelon 749/749; both builds have zero warnings/errors.
  • Five regression cases cover the new name, both names, legacy-only games, valid layer zero, and missing layers.
  • IL2CPP live game 0.4.7f9: clean isolated install with the user's unchanged Forklift & Pallets and Mods App DLLs, loading a disposable copy of a completed save. Released beta.7 and the current unmodified beta head both reproduced repeated transparent pallet captures. With this patch, the consumer generated its 512px pallet inventory icon; the resulting image was inspected. A separate native-material cube capture returned visible 128x128 pixels, with original parent, position, and active state restored.
  • Mono live game 0.4.7f7 Alternate: separate isolated install; visible 128x128 capture and transform/active-state restoration verified. Actual Forklift & Pallets and Mods App consumers were tested only on IL2CPP 0.4.7f9.
  • DocFX succeeded (4 warnings, no errors); public API documentation coverage 82.43%, above the 80% gate. git diff --check passed.
  • Game assemblies, decompilation, disposable probes, saves, captures, and test installs stay local and are excluded from the PR. Original game installs and save fixtures were not changed.

Compatibility

No public/protected symbols, signatures, parameter names, attributes, defaults, item IDs, save formats, or network contracts change. The default size remains 512. Explicit sizes now behave as documented. The layer lookup retains the legacy name for older layer layouts; this PR targets the beta game's native overload. Missing layers retain the null/failure path and now produce a specific error. Source and binary API shape are unchanged; render behavior is repaired.

The separate missing Mods App report is already addressed by merged #333: on the same 0.4.7f9 install, beta.7 had no Mods icon, while the current beta head restored it before any changes in this PR. That fix is still unreleased.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d8455573-0444-473e-90c5-b113a7ffe875

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ifBars ifBars added beta A game update on the beta & alternate-beta steam branches bug Something isn't working labels Oct 4, 2026
@ifBars
ifBars merged commit 0a14623 into beta Oct 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta A game update on the beta & alternate-beta steam branches bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant