fix(rendering): restore beta item icons and requested capture size - #345
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schedule I beta 0.4.7f9 renamed the preview layer to
RuntimePreviewGeneration.IconFactorystill looked upIconGeneration, which returns-1, leaving custom models outside the native preview camera's layer. Forklift & Pallets 1.2.0 consequently exhausted its retries with transparent pallet icons.Resolve the current layer with a legacy-name fallback, report a missing preview layer explicitly, and pass the caller's
sizeinto the beta nativeGetTextureoverload. Previously that argument was ignored and native captures always used 512.Validation
betaatc3ec3a22f7a0d85439287acb6d36b5b30f66f84d.git diff --checkpassed.Compatibility
No public/protected symbols, signatures, parameter names, attributes, defaults, item IDs, save formats, or network contracts change. The default size remains 512. Explicit sizes now behave as documented. The layer lookup retains the legacy name for older layer layouts; this PR targets the beta game's native overload. Missing layers retain the null/failure path and now produce a specific error. Source and binary API shape are unchanged; render behavior is repaired.
The separate missing Mods App report is already addressed by merged #333: on the same 0.4.7f9 install, beta.7 had no Mods icon, while the current beta head restored it before any changes in this PR. That fix is still unreleased.