fix(NPC): prevent post-load custom contact reinitialization on beta

[ifBars]

Summary

Fixes the post-load crash reported in #315 for plain custom contacts on the 0.4.7f6 game beta. S1API needs NPCData during inactive construction, but native NPC.Awake must initialize its own data from the configured data object. The previous handoff left NPCData populated, so native Awake deinitialized the contact before initializing it again.

The existing NPC Awake prefix now releases construction-time NPCData for S1API custom NPCs that have a framework data object. It recognizes both modern prefabs with NPCPrefabIdentity and legacy contacts registered by ID. Native Awake then initializes the data once.

This targets beta for the planned 3.2.1-beta.5 release alongside the already merged #316. This PR does not bump or publish a version.

Reproduction

• Published 3.2.1-beta.4 on Steam build 25439817 (IL2CPP, MelonLoader 0.7.3), with the two-contact 3.2.1-beta.2 on 0.4.7f6: plain custom NPCs fail to construct, legacy and ConfigurePrefab paths alike ("The custom NPC prefab has no framework data object") #309 repro: both contacts registered, then the process exited with 0xc0000005. Player.log ended after InitializeNPC called on already initialized NPC. First deinitializing....
• The earlier 3.2.1-beta.2 on 0.4.7f6: plain custom NPCs fail to construct, legacy and ConfigurePrefab paths alike ("The custom NPC prefab has no framework data object") #309 smoke probe ended as soon as registration succeeded; this run stayed in playable gameplay after registration to catch the delayed crash.

Verification

• Fixed IL2CPP build on the same f6 install: both contacts entered native Awake with NPCData unset, exited with it initialized, and remained registered in playable gameplay for 15 seconds. No duplicate-initialization warning appeared.
• Fixed Mono f6 build: both contacts remained registered in playable gameplay for 15 seconds.
• dotnet build S1API.sln and the full S1API.Tests suite passed separately in MonoMelon (724 tests) and Il2CppMelon (710 tests).
• The isolated smoke runner restored both game installs after each run. The synthetic IL2CPP fixture logged an Eye.StopEyeCoroutines null reference during game shutdown, after the passing result; it did not occur during the measured post-load window.

Compatibility

No public or protected API, save format, network payload, or identifier changes. Construction-time data remains available until native Awake. The handoff changes only S1API custom NPCs with a configured framework data object; vanilla NPCs and objects without one keep their existing Awake behavior.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: e1dd8a00-ee6a-44c2-844a-54a41790d6f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}